Create New Vault test improvements #18259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [9a68b05]
Page Load Metrics (1495 ± 28 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18259 +/- ##
===========================================
+ Coverage 65.15% 65.23% +0.08%
===========================================
Files 936 936
Lines 35965 35963 -2
Branches 9231 9231
===========================================
+ Hits 23432 23459 +27
+ Misses 12533 12504 -29
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [47809c9]
Page Load Metrics (1635 ± 62 ms)
Bundle size diffs
|
Builds ready [abba078]
Page Load Metrics (1598 ± 52 ms)
Bundle size diffs
|
Builds ready [93fab6f]
Page Load Metrics (1742 ± 62 ms)
Bundle size diffs
|
Builds ready [f8c2099]
Page Load Metrics (1566 ± 45 ms)
Bundle size diffs
|
Builds ready [1dea111]
Page Load Metrics (1569 ± 36 ms)
Bundle size diffs
|
Builds ready [fde9f22]
Page Load Metrics (1618 ± 44 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Mar 30, 2023
Builds ready [08e8250]
Page Load Metrics (1615 ± 57 ms)
Bundle size diffs
|
Builds ready [dec423b]
Page Load Metrics (1569 ± 43 ms)
Bundle size diffs
|
Builds ready [79aae71]
Page Load Metrics (1493 ± 39 ms)
Bundle size diffs
|
Builds ready [a7b765e]
Page Load Metrics (1673 ± 64 ms)
Bundle size diffs
|
Builds ready [c54c3ec]
Page Load Metrics (1807 ± 88 ms)
|
Builds ready [2e96067]
Page Load Metrics (1769 ± 62 ms)
Bundle size diffs
|
Builds ready [0c716e3]
Page Load Metrics (1878 ± 57 ms)
Bundle size diffs
|
Builds ready [979b106]
Page Load Metrics (1594 ± 41 ms)
Bundle size diffs
|
Builds ready [065160c]
Page Load Metrics (1477 ± 51 ms)
Bundle size diffs
|
Builds ready [6d8d5a8]
Page Load Metrics (1596 ± 42 ms)
Bundle size diffs
|
Builds ready [f5c3e32]
Page Load Metrics (1625 ± 60 ms)
Bundle size diffs
|
brad-decker
approved these changes
Apr 19, 2023
Builds ready [a7643f9]
Page Load Metrics (1681 ± 69 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Create New Vault test improvements.
Broken apart from #17360.
Partially completes #17191
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.