Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Update snap authorship component #18262

Merged
merged 9 commits into from
Mar 24, 2023

Conversation

FrederikBolding
Copy link
Member

Explanation

Implemented new snap authorship component.

Fixes #18237

Screenshots/Screencaps

Before

image

After

image

@metamaskbot
Copy link
Collaborator

Builds ready [d27c542]
Page Load Metrics (1635 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint922101292412
domContentLoaded1464177116238038
load1482185316359244
domInteractive1464177116238038
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@8c310a0). Click here to learn what that means.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             develop   #18262   +/-   ##
==========================================
  Coverage           ?   64.51%           
==========================================
  Files              ?      913           
  Lines              ?    35327           
  Branches           ?     9071           
==========================================
  Hits               ?    22788           
  Misses             ?    12539           
  Partials           ?        0           
Impacted Files Coverage Δ
ui/helpers/utils/util.js 85.42% <25.00%> (ø)
...ect-header/permissions-connect-header.component.js 91.67% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

{iconUrl ? (
<AvatarFavicon size={Size.LG} src={iconUrl} />
) : (
<AvatarBase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we componentize this as e.g. <SnapAvatar /> on a snaps-app-level so it can be used consistently across our UI? I have a feeling this will be used quite often going forward.

I know for example @david0xd will be needing it on the settings page as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, doing this now 👍

@FrederikBolding FrederikBolding dismissed a stale review via d19f006 March 23, 2023 11:06
@FrederikBolding FrederikBolding marked this pull request as ready for review March 23, 2023 11:35
@FrederikBolding FrederikBolding requested a review from a team as a code owner March 23, 2023 11:35
@metamaskbot
Copy link
Collaborator

Builds ready [698980c]
Page Load Metrics (1636 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91147121189
domContentLoaded1514180416188842
load15141932163610751
domInteractive1514180416188842
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@FrederikBolding FrederikBolding merged commit 4179ce6 into develop Mar 24, 2023
@FrederikBolding FrederikBolding deleted the fb/new-snap-authorship branch March 24, 2023 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snaps authorship component
5 participants