-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Update snap authorship component #18262
Conversation
Builds ready [d27c542]
Page Load Metrics (1635 ± 44 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18262 +/- ##
==========================================
Coverage ? 64.51%
==========================================
Files ? 913
Lines ? 35327
Branches ? 9071
==========================================
Hits ? 22788
Misses ? 12539
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
{iconUrl ? ( | ||
<AvatarFavicon size={Size.LG} src={iconUrl} /> | ||
) : ( | ||
<AvatarBase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we componentize this as e.g. <SnapAvatar />
on a snaps-app-level so it can be used consistently across our UI? I have a feeling this will be used quite often going forward.
I know for example @david0xd will be needing it on the settings page as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, doing this now 👍
Builds ready [698980c]
Page Load Metrics (1636 ± 51 ms)
Bundle size diffs
|
Explanation
Implemented new snap authorship component.
Fixes #18237
Screenshots/Screencaps
Before
After