Github action to check issue body matches issues templates and add labels to issue when needed #21184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tected with a label The new bug report template makes it mandatory to indicate what release version the bug was detected in. We want to exploit that information by extracting the version number from issue body and indicate it by adding corresponding regression prod label on the issue. In addition to it, we also want to add a label to indicate when the bug has been reported by someone external to the MetaMask organisation. We will be able to leverage these two new labels to improve our bug triage process and our metrics collection.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
14 tasks
gauthierpetetin
added
in-progress
needs-dev-review
…s to achieve The github action was initially only meant to add regression-prod labels while the scope is nox extended, which is why it's worth renaming a few things to reflect it.
Builds ready [a7778a0]
Page Load Metrics (810 ± 373 ms)
Bundle size diffs
|
gauthierpetetin
changed the title
brad-decker
previously approved these changes
Oct 5, 2023
pedronfigueiredo
previously approved these changes
Oct 10, 2023
Builds ready [3b4b907]
Page Load Metrics (635 ± 352 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #21184 +/- ##
========================================
Coverage 68.62% 68.62%
========================================
Files 1018 1018
Lines 40828 40828
Branches 10901 10901
========================================
Hits 28015 28015
Misses 12813 12813 ☔ View full report in Codecov by Sentry. |
Builds ready [7eb06e6]
Page Load Metrics (1015 ± 357 ms)
Bundle size diffs
|
…iles Nicholas Ellul raised that the script would not be able to retrieve list of organisations for users who have their GitHub set to private mode. As a consequence, these users would appear as external contributors while they are not. This commit introduces a different way to check if users belong to the MetaMask organisation, which allows to support even users with private profiles.
gauthierpetetin
dismissed stale reviews from pedronfigueiredo and brad-decker
via
df4ea3f
gauthierpetetin
requested review from
NicholasEllul,
brad-decker and
pedronfigueiredo
Builds ready [df4ea3f]
Page Load Metrics (643 ± 355 ms)
Bundle size diffs
|
brad-decker
approved these changes
Oct 11, 2023
gauthierpetetin
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Oct 11, 2023
…d labels to issue when needed (#7379) ## **Description** This PR introduces a new Github action, to achieve the following: 1. Check if issue matches an existing issue template ('general-issue.yml' or 'bug-report.yml') 2. Add an `INVALID-ISSUE-TEMPLATE` label in case issue doesn't match any of the templates 3. Add an `external-contributor` label in case issue was created by someone external to the MetaMask organisation 4. Add a `regression-prod-x.y.z` label when possible, when `x.y.z` value can be extracted from 'bug-report.yml' template We will be able to leverage `regression-prod-x.y.z` and `external-contributor` labels to improve our bug triage process and our metrics collection. [Same PR for Extension repo](MetaMask/metamask-extension#21184) ## **Manual testing steps** 1. Go on this [test repo](https://github.com/gauthierpetetin-test/repo_test/issues/new?assignees=&labels=type-bug&projects=&template=bug-report-extension.yml&title=%5BBug%5D%3A+) 2. Fill the bug report issue form 6. Make sure the release version you indicate in the form has x.y.z format 7. Click on "Submit new issue" 8. Wait for ~30s and 2 new labels shall appear on the issue you just created (`regression-prod-x.y.z` and `external-contributor`) 9. Edit the issue's description by indicating a different release version 10. Wait for ~30s and the `regression-prod-x.y.z` shall be updated accordingly 11. Edit the issue by deleting the whole description 12. Wait for ~30s and the `INVALID-ISSUE-TEMPLATE` shall be added ## **Screenshots/Recordings** ### **Before** NA ### **After** https://recordit.co/Sq7fvCwkr5 ## **Related issues** Fixes MetaMask/mobile-planning#1293 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [ ] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cal Leung <cleun007@gmail.com>
pedronfigueiredo
approved these changes
Oct 12, 2023
github-actions
bot
removed
the
needs-dev-review
metamaskbot
added
the
release-11.4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new Github action, to achieve the following:
INVALID-ISSUE-TEMPLATElabel in case issue doesn't match any of the templatesexternal-contributorlabel in case issue was created by someone external to the MetaMask organisationregression-prod-x.y.zlabel when possible, whenx.y.zvalue can be extracted from 'bug-report.yml' templateWe will be able to leverage
regression-prod-x.y.zandexternal-contributorlabels to improve our bug triage process and our metrics collection.Same PR for Mobile repo
Manual testing steps
regression-prod-x.y.zandexternal-contributor)regression-prod-x.y.zshall be updated accordinglyINVALID-ISSUE-TEMPLATEshall be addedScreenshots/Recordings
Before
NA
After
https://recordit.co/Sq7fvCwkr5
Related issues
Fixes https://github.com/MetaMask/MetaMask-planning/issues/1409
Pre-merge author checklist
Pre-merge reviewer checklist