Don't pass origin as an HTTP header #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests with this nonstandard header are being blocked by CORS when made against Parity. Not sending it ought to fix MetaMask#1779.
|
@kumavis Can you speak to why you added this header? Does it make sense to remove it? |
|
@interfect the header is mostly added as a debugging mechanism, to track what dapp is making the rpc request. We also use it to yell at dapp devs when they are spamming the hell out of our network. I agree this header does not need to be set in all cases - will look into setting it only under infura config. |
frankiebee
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1779.
That issue seems to be caused by MetaMask demanding to send the
x-metamask-originheader, and Ethereum nodes responding with CORS responses that disallow that header. I posted a Wireshark dump in #1779 that illustrates the problem.This is a different fix than #2138. In particular, this fix is compatible with the "Custom RPC" option; in general the extension needs to be able to make requests against arbitrary user-submitted Ethereum nodes, and they can't all be put in the manifest to be exempted from proper CORS checking.
On the other hand, this fix just removes the
x-metamask-originheader, which presumably was added for a reason. However, since apparently neither Infura nor Parity send CORS responses allowing this header, I don't think it's really tenable to have MetaMask try and send it. If it's really needed for Infura, it should be sent only when Infura is the node provider, until non-Infura nodes can tolerate it.