Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IoTeX logo and update config #23744

Closed
wants to merge 7 commits into from

Conversation

nicky-ru
Copy link

@nicky-ru nicky-ru commented Mar 26, 2024

Description

This pull request introduces the addition of the IoTeX mainnet logo to the MetaMask extension and updates the necessary configuration files to support this change.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Open and connect: Begin by navigating to the Chainlist website. Use the following link to directly access the search results for IoTeX: https://chainlist.org/?search=iotex. Upon arrival, connect your MetaMask extension to the site.
  2. Add network: In the search results, locate 'IoTeX Mainnet'. Next to it, you'll find a button to 'Add to Metamask'. Click this button to initiate the process of adding the IoTeX Mainnet network to your MetaMask.
  3. Verify Logo Presence: After successfully adding the network, open your MetaMask extension and switch to the IoTeX Mainnet. You should now observe the IoTeX logo accompanying the network's name, indicating successful integration.

Screenshots/Recordings

Before

Screenshot 2024-03-26 at 10 49 03 PM

After

Screenshot 2024-03-26 at 11 57 12 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Mar 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nicky-ru
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@nicky-ru nicky-ru marked this pull request as ready for review March 26, 2024 21:47
@nicky-ru nicky-ru requested a review from a team as a code owner March 26, 2024 21:47
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label May 25, 2024
Copy link
Contributor

github-actions bot commented Jun 8, 2024

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Jun 8, 2024
@gambinish gambinish reopened this Aug 19, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request adds support for the IoTeX mainnet logo in the MetaMask extension by updating the network configuration.

  • Added IoTeX mainnet details in shared/constants/network.ts, including chain ID, currency symbol, and logo URL
  • Consistent implementation with existing network configurations in the file
  • New logo will be displayed when users add or switch to the IoTeX mainnet network
  • Manual testing steps provided to verify the logo's presence in the MetaMask UI
  • Before and after screenshots demonstrate the successful integration of the IoTeX logo

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@gambinish gambinish added team-assets and removed stale issues and PRs marked as stale labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (81af2e8) to head (0444b56).
Report is 39 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23744      +/-   ##
===========================================
+ Coverage    69.96%   70.10%   +0.14%     
===========================================
  Files         1405     1413       +8     
  Lines        48996    49259     +263     
  Branches     13697    13769      +72     
===========================================
+ Hits         34280    34531     +251     
- Misses       14716    14728      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review.

216 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

gambinish
gambinish previously approved these changes Aug 20, 2024
vinnyhoward
vinnyhoward previously approved these changes Aug 21, 2024
@vinnyhoward
Copy link
Contributor

vinnyhoward commented Aug 21, 2024

This PR is approved as it accomplishes its main goal. The network image has been added successfully. However, please note that the token image is still missing. If you'd like to add the token image as well, feel free to do so in a separate PR.
Screenshot 2024-08-21 at 4 17 38 PM

@nicky-ru nicky-ru dismissed stale reviews from vinnyhoward and gambinish via 8454d10 August 22, 2024 18:41
@nicky-ru
Copy link
Author

@gambinish @vinnyhoward thanks for the catch! just pushed an update with the token img:

Screenshot 2024-08-23 at 2 38 58 AM

@gambinish gambinish self-requested a review August 22, 2024 22:35
gambinish
gambinish previously approved these changes Aug 22, 2024
app/images/iotex.svg Show resolved Hide resolved
@gambinish
Copy link
Contributor

Not sure why SonarCloud is failing. Going to open a PR separately with these same changes. I expect it has something to do with the timing of this PR.

Here is the other one: #26723

@gambinish gambinish closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants