-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IoTeX logo and update config #23744
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions. |
This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request adds support for the IoTeX mainnet logo in the MetaMask extension by updating the network configuration.
- Added IoTeX mainnet details in
shared/constants/network.ts
, including chain ID, currency symbol, and logo URL - Consistent implementation with existing network configurations in the file
- New logo will be displayed when users add or switch to the IoTeX mainnet network
- Manual testing steps provided to verify the logo's presence in the MetaMask UI
- Before and after screenshots demonstrate the successful integration of the IoTeX logo
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23744 +/- ##
===========================================
+ Coverage 69.96% 70.10% +0.14%
===========================================
Files 1405 1413 +8
Lines 48996 49259 +263
Branches 13697 13769 +72
===========================================
+ Hits 34280 34531 +251
- Misses 14716 14728 +12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No major changes found since last review.
216 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@gambinish @vinnyhoward thanks for the catch! just pushed an update with the token img: |
Not sure why SonarCloud is failing. Going to open a PR separately with these same changes. I expect it has something to do with the timing of this PR. Here is the other one: #26723 |
Description
This pull request introduces the addition of the IoTeX mainnet logo to the MetaMask extension and updates the necessary configuration files to support this change.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist