Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding a new controller for Metametrics Data Deletion #24503
feat: Adding a new controller for Metametrics Data Deletion #24503
Changes from all commits
5dce95e
e1200ab
e175f0c
eaba4e5
666b723
74b4720
f0c988a
9dd231d
a9dba40
7bfb0b8
a60c9c5
aa59115
850fd00
ac041f5
f01ec84
63ae627
eb45e7b
dda5a2b
b0bd00d
9109601
7c8ed9d
5aeb0c2
c92183b
14b8df0
bcbf1c6
fb49511
19f8fc2
8fdadd1
f6ff9a6
6f8ba43
3831b9c
bc25613
2273c5f
330313e
cc9a5ee
5e02705
31b3b66
102b024
5fa9f65
631a80d
3a9be3b
d03f030
2148e37
e7e6dcf
98cefc6
cc92dee
12db029
d5f2d75
6a77df8
28e4eec
886abe4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should clear
metaMetricsDataDeletionStatus
here as well. If it's set, then it must have been pertaining to a previous deletion request, so it would be inaccurate at this point.The same goes for
hasMetaMetricsDataRecorded
as well, though in my other comment I suggest removing that state altogether.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NiranjanaBinoy was this comment addressed? I see that
this.updateDataDeletionTaskStatus()
is called, but it does not clear the status, rather it updates itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now
metaMetricsDataDeletionStatus
will get updated with the current/newest request status with this call tothis.updateDataDeletionTaskStatus()
.