-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add retry policy to the data deletion service #24716
Merged
NiranjanaBinoy
merged 5 commits into
delete-metametrics-data-controller
from
delete-metametrics-data-controller-service-refactor
May 24, 2024
Merged
feat: Add retry policy to the data deletion service #24716
NiranjanaBinoy
merged 5 commits into
delete-metametrics-data-controller
from
delete-metametrics-data-controller-service-refactor
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
delete-metametrics-data-controller-service-refactor
branch
3 times, most recently
from
May 22, 2024 18:47
3dc92b1
to
c7dc3eb
Compare
NiranjanaBinoy
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
NiranjanaBinoy
force-pushed
the
delete-metametrics-data-controller
branch
from
May 23, 2024 15:07
75158b0
to
1b8ad2a
Compare
Gudahtt
force-pushed
the
delete-metametrics-data-controller-service-refactor
branch
2 times, most recently
from
May 23, 2024 22:38
8cd68bb
to
4e12767
Compare
The data deletion service now uses a retry policy. It has been refactored into a class so that the retry state may be stored as an instance variable. The service is now injected as well, rather than imported, to keep it decoupled from the controller and make testing easier.
Gudahtt
force-pushed
the
delete-metametrics-data-controller-service-refactor
branch
from
May 24, 2024 16:05
4e12767
to
4ae47b6
Compare
@metamaskbot update-policies |
Policies updated |
NiranjanaBinoy
merged commit May 24, 2024
81e9b11
into
delete-metametrics-data-controller
64 of 66 checks passed
NiranjanaBinoy
deleted the
delete-metametrics-data-controller-service-refactor
branch
May 24, 2024 18:21
Builds ready [4454d6d]
Page Load Metrics (394 ± 371 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The data deletion service now uses a retry policy. It has been refactored into a class so that the retry state may be stored as an instance variable. The service is now injected as well, rather than imported, to keep it decoupled from the controller and make testing easier.
The new service class and retry policy is modelled after the token price service in core: https://github.com/MetaMask/core/blob/3165e87096300a66e06bd949dde736f90ca24fbc/packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Related issues
This is a suggested change for #24503
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
(omitting - not applicable as this isn't targeting
develop
)Pre-merge reviewer checklist