-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: permit signature copy changes #24975
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24975 +/- ##
===========================================
+ Coverage 65.65% 65.67% +0.02%
===========================================
Files 1368 1368
Lines 54269 54302 +33
Branches 14192 14207 +15
===========================================
+ Hits 35627 35659 +32
- Misses 18642 18643 +1 ☔ View full report in Codecov by Sentry. |
Builds ready [28b2591]
Page Load Metrics (56 ± 6 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! one thing related to an updated translation that I think needs to be addressed before approving
I think the Fixes: ticket in the description needs to be updated
91ee72e
to
010a1e0
Compare
010a1e0
to
feb8367
Compare
feb8367
to
228f73b
Compare
Builds ready [228f73b]
Page Load Metrics (53 ± 4 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Copy changes in permit signature.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2578
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist