Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a min-width value in the notifications-tag-counter #25322

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jun 14, 2024

Description

This PR introduces a fix for a bug related to the UI of the notifications-tag-counter component. The component now has a min-width to prevent the tag from appearing squished in the case of a single character.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

Screenshot 2024-06-14 at 11 58 07

After

Screenshot 2024-06-14 at 14 54 30 Screenshot 2024-06-14 at 14 54 35

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications Notifications team label Jun 14, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati marked this pull request as ready for review June 14, 2024 13:16
@matteoscurati matteoscurati requested a review from a team as a code owner June 14, 2024 13:16
dovydas55
dovydas55 previously approved these changes Jun 14, 2024
@matteoscurati matteoscurati dismissed stale reviews from dovydas55 and Prithpal-Sooriya via 2f396d3 June 14, 2024 13:52
@matteoscurati matteoscurati requested a review from a team as a code owner June 14, 2024 13:52
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (4aa2fd0) to head (4a25ca5).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25322   +/-   ##
========================================
  Coverage    65.70%   65.70%           
========================================
  Files         1377     1377           
  Lines        54624    54624           
  Branches     14318    14318           
========================================
  Hits         35886    35886           
  Misses       18738    18738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4a25ca5]
Page Load Metrics (49 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711038294
domContentLoaded8131011
load40634984
domInteractive8131011
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 102 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati merged commit 62ca8ad into develop Jun 14, 2024
74 checks passed
@matteoscurati matteoscurati deleted the fix/notifications-tag-counter-width branch June 14, 2024 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants