-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use a min-width value in the notifications-tag-counter #25322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Prithpal-Sooriya
previously approved these changes
Jun 14, 2024
dovydas55
previously approved these changes
Jun 14, 2024
matteoscurati
dismissed stale reviews from dovydas55 and Prithpal-Sooriya
via
June 14, 2024 13:52
2f396d3
Prithpal-Sooriya
approved these changes
Jun 14, 2024
dovydas55
approved these changes
Jun 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25322 +/- ##
========================================
Coverage 65.70% 65.70%
========================================
Files 1377 1377
Lines 54624 54624
Branches 14318 14318
========================================
Hits 35886 35886
Misses 18738 18738 ☔ View full report in Codecov by Sentry. |
Builds ready [4a25ca5]
Page Load Metrics (49 ± 4 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.1.0
Issue or pull request that will be included in release 12.1.0
label
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.1.0
Issue or pull request that will be included in release 12.1.0
team-notifications
Notifications team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a fix for a bug related to the UI of the
notifications-tag-counter
component. The component now has a min-width to prevent the tag from appearing squished in the case of a single character.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist