-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added BTC variant to ramps-card and illustration image #25615
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [ba02869]
Page Load Metrics (476 ± 345 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25615 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48173 48173
Branches 13291 13291
========================================
Hits 33527 33527
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Description
Updates the Ramps banners for BTC accounts.
Added
BTC
toRAMPS_CARD_VARIANT_TYPES
withillustractionSrc
,gradient
,title
, andbody
in theRAMPS_CARD_VARIANTS
app/images
BtcBanner
toRampsMetaMaskEntry
enumRelated issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/496
Manual testing steps
N/A
@georgeweiler is working on subsequent PR to include BTC in the list of buyable tokens, which will render the new banner in that flow.
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist