Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed max width for permissions page #25870

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix: fixed max width for permissions page #25870

merged 3 commits into from
Jul 19, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Jul 16, 2024

For full screen view, the permissions page width should follow the page size what we have for other screens

Related issues

Fixes: #25678

Manual testing steps

  1. Go to Full Screen View
  2. Go to Permissions Page
  3. Check the Permissions Page has same width as the other pages

Screenshots/Recordings

Before

Screenshot 2024-07-16 at 6 30 05 PM

After

Screenshot 2024-07-16 at 6 26 32 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner July 16, 2024 17:26
@NidhiKJha NidhiKJha changed the title fix: fixed max width fix: fixed max width for permissions page Jul 16, 2024
@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 16, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [77b178c]
Page Load Metrics (66 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7412097126
domContentLoaded105227115
load469566136
domInteractive105227115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 42 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.70%. Comparing base (e562224) to head (77b178c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25870   +/-   ##
========================================
  Coverage    69.70%   69.70%           
========================================
  Files         1400     1400           
  Lines        49464    49464           
  Branches     13687    13687           
========================================
  Hits         34478    34478           
  Misses       14986    14986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha merged commit 61c7d16 into develop Jul 19, 2024
79 checks passed
@NidhiKJha NidhiKJha deleted the fix-max-width branch July 19, 2024 12:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Accounts - All Permissions screens are displayed in full width when we are in the extension window view
4 participants