-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed max width for permissions page #25870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
changed the title
fix: fixed max width
fix: fixed max width for permissions page
Jul 16, 2024
NidhiKJha
added
team-wallet-ux
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
labels
Jul 16, 2024
sahar-fehri
approved these changes
Jul 17, 2024
Builds ready [77b178c]
Page Load Metrics (66 ± 6 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25870 +/- ##
========================================
Coverage 69.70% 69.70%
========================================
Files 1400 1400
Lines 49464 49464
Branches 13687 13687
========================================
Hits 34478 34478
Misses 14986 14986 ☔ View full report in Codecov by Sentry. |
salimtb
approved these changes
Jul 19, 2024
metamaskbot
added
the
release-12.3.0
Issue or pull request that will be included in release 12.3.0
label
Jul 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.3.0
Issue or pull request that will be included in release 12.3.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For full screen view, the permissions page width should follow the page size what we have for other screens
Related issues
Fixes: #25678
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist