Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix overlapping modals #25962

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: fix overlapping modals #25962

merged 1 commit into from
Jul 19, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Jul 19, 2024

Description

Fixes overlapping modals

Open in GitHub Codespaces

Related issues

Fixes:#25465

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-07-19.at.09.40.22.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner July 19, 2024 07:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 19, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [63084f1]
Page Load Metrics (418 ± 324 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7273513914570
domContentLoaded9135313115
load462052418674324
domInteractive9135303115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.70%. Comparing base (e562224) to head (63084f1).
Report is 6 commits behind head on develop.

Files Patch % Lines
ui/pages/home/home.component.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25962      +/-   ##
===========================================
- Coverage    69.70%   69.70%   -0.00%     
===========================================
  Files         1400     1400              
  Lines        49464    49465       +1     
  Branches     13687    13688       +1     
===========================================
  Hits         34478    34478              
- Misses       14986    14987       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahar-fehri sahar-fehri merged commit 29936c5 into develop Jul 19, 2024
89 of 90 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-overlapping-modals branch July 19, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants