fix: Revert "refactor: use withKeyring method (#25435)"

[seaona]

Description

Revert "refactor: use withKeyring

Related issues

Fixes: ci failures for Create Snap accounts

Manual testing steps

1. check ci for ff and ff flask

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/92931/workflows/0e8fb7fe-e5bb-4cec-816c-eed6a97c0d45/jobs/3461246/steps

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/92931/workflows/0e8fb7fe-e5bb-4cec-816c-eed6a97c0d45/jobs/3461243

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 65.75342% with 25 lines in your changes missing coverage. Please review.

Project coverage is 69.67%. Comparing base (9395988) to head (ff84119).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
app/scripts/metamask-controller.js	65.75%	25 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26041   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1404     1404           
  Lines        49682    49680    -2     
  Branches     13726    13730    +4     
========================================
  Hits         34614    34614           
+ Misses       15068    15066    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[greptile-apps]

PR Summary

Reverted the use of the withKeyring method in metamask-controller.js and updated corresponding tests in metamask-controller.test.js.

• app/scripts/metamask-controller.js: Replaced withKeyring with direct calls to getKeyringForDevice in hardware wallet methods.
• app/scripts/metamask-controller.test.js: Reverted method names from withKeyringForDevice back to getKeyringForDevice and added new test cases for addNewKeyring and addNewAccountForKeyring.

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[metamaskbot]

Builds ready [ff84119]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (224 ± 229 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	141	97	15	7
		domContentLoaded	10	61	27	13	6
		load	40	1781	224	477	229
		domInteractive	9	61	26	13	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: -225 Bytes (-0.01%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)