fix: flaky test Import flow @no-mmi Import wallet using Secret Recovery Phrase with pasting word by word

[seaona]

Description

The test Import flow @no-mmi Import wallet using Secret Recovery Phrase with pasting word by word fails because after opting out from metametrics, we land into the Home page again instead of going to the Import SRP page, causing the test to fail as the srp element cannot be located (ci failure).

This is a race condition on the wallet level, and not on the test level: iinstead of going inside the ONBOARDING_IMPORT_WITH_SRP_ROUTE condition, we fallback to the DEFAULT_ROUTE which directs you to home (see screenshot of the failure):

export function getFirstTimeFlowTypeRouteAfterMetaMetricsOptIn(state) {
  const { firstTimeFlowType } = state.metamask;

  if (firstTimeFlowType === FirstTimeFlowType.create) {
    return ONBOARDING_CREATE_PASSWORD_ROUTE;
  } else if (firstTimeFlowType === FirstTimeFlowType.import) {
    return ONBOARDING_IMPORT_WITH_SRP_ROUTE;
  } else if (firstTimeFlowType === FirstTimeFlowType.restore) {
    return ONBOARDING_SECURE_YOUR_WALLET_ROUTE;
  }
  return DEFAULT_ROUTE;
}

I am able to consistently reproduce it locally if I add a timeout in the onImportClick function:

  const onImportClick = async () => {
    setTimeout(async () => {
    dispatch(setFirstTimeFlowType(FirstTimeFlowType.import));
    }, 200);

Related issues

Fixes: #26053

Manual testing steps

1. Check ci hasn''t failed anymore with the Import flow @no-mmi Import wallet using Secret Recovery Phrase with pasting word by word

Screenshots/Recordings

Race condition which lands me back to HOME page:

race-condition-import-flow.mp4

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[greptile-apps]

PR Summary

This pull request addresses a race condition in the onboarding flow by ensuring asynchronous actions are properly awaited.

• ui/pages/onboarding-flow/welcome/welcome.js: Made dispatch call in onImportClick function asynchronous to prevent race conditions.
• ui/pages/onboarding-flow/welcome/welcome.test.js: Updated tests to use waitFor for asynchronous actions, improving test reliability.
• ui/store/actions.ts: Modified setFirstTimeFlowType to return a Promise<void> and use async/await for better async handling.

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[metamaskbot]

Builds ready [1f07bb2]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (167 ± 203 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	158	98	22	11
		domContentLoaded	9	62	25	14	7
		load	43	2010	167	423	203
		domInteractive	9	62	25	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 6 Bytes (0.00%)
• common: 20 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.68%. Comparing base (a3c4333) to head (1f07bb2).
Report is 2 commits behind head on develop.

Files	Patch %	Lines
ui/store/actions.ts	0.00%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26049   +/-   ##
========================================
  Coverage    69.68%   69.68%           
========================================
  Files         1405     1405           
  Lines        49701    49701           
  Branches     13738    13737    -1     
========================================
  Hits         34630    34630           
  Misses       15071    15071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danjm]

LGTM!