fix: 🐛 use a counter to show if there are pending transactions #26116

matteoscurati · 2024-07-25T08:17:20Z

Description

This PR modifies the content of the badge for pending transactions. Before this PR, the blue badge showed three dots; now it shows a number again.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-25T08:17:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matteoscurati · 2024-07-25T08:21:29Z

More info https://consensys.slack.com/archives/CTQAGKY5V/p1720826265502299

metamaskbot · 2024-07-25T08:48:49Z

Builds ready [08c707d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (179 ± 219 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	186	113	26	13
		domContentLoaded	10	69	27	15	7
		load	43	2164	179	456	219
		domInteractive	10	69	27	15	7

Bundle size diffs [🚀 Bundle size reduced!]

background: -4 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-07-25T08:49:15Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (ed28508) to head (7e6b5d7).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
app/scripts/background.js	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26116   +/-   ##
========================================
  Coverage    69.95%   69.95%           
========================================
  Files         1411     1411           
  Lines        49982    49981    -1     
  Branches     13805    13804    -1     
========================================
  Hits         34964    34964           
+ Misses       15018    15017    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greptile-apps

PR Summary

This PR updates the badge for pending transactions to display the number of pending transactions instead of an ellipsis, enhancing user experience by providing specific information.

File Modified: app/scripts/background.js
Key Changes:
- Removed BADGE_LABEL_APPROVAL constant.
- Updated updateBadge function to set the badge label to pendingApprovalCount.

This change ensures users can see the exact number of pending transactions, improving transparency and usability.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

metamaskbot · 2024-07-25T13:22:02Z

Builds ready [6e0d269]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (241 ± 233 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	150	111	18	9
		domContentLoaded	10	68	31	16	8
		load	55	1712	241	484	233
		domInteractive	10	68	31	16	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -4 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

greptile-apps

PR Summary

(updates since last review)

This PR updates the badge for pending transactions to display the number of pending transactions instead of an ellipsis, enhancing user experience by providing specific information.

File Modified: ui/pages/confirmations/confirm-transaction-base/confirm-transaction-base.container.js
- Added state mapping for unapproved transactions and their counts.
- Introduced a counter to track the number of pending transactions.
File Added: ui/pages/confirmations/confirmation/components/queued-requests-banner-alert/queued-requests-banner-alert.tsx
- Introduced QueuedRequestsBannerAlert component to display a banner alert for queued requests.
File Modified: ui/pages/confirmations/components/signature-request/signature-request.js
- Added QueuedRequestsBannerAlert component to the SignatureRequest component.
File Added: ui/pages/confirmations/hooks/alerts/transactions/useQueuedConfirmationsAlerts.ts
- Introduced useQueuedConfirmationsAlerts hook to generate alerts for queued confirmations.
File Modified: ui/pages/confirmations/hooks/useConfirmationAlerts.ts
- Integrated useQueuedConfirmationsAlerts into useTransactionAlerts function.

These changes ensure users can see the exact number of pending transactions, improving transparency and usability.

_{78 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

app/scripts/background.js

metamaskbot · 2024-07-26T14:55:55Z

Builds ready [7a83fcb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (277 ± 287 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	188	122	31	15
		domContentLoaded	9	63	33	15	7
		load	40	2440	277	597	287
		domInteractive	9	63	33	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-08-01T07:38:28Z

Builds ready [634bec5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (274 ± 271 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	892	167	176	85
		domContentLoaded	10	123	42	34	16
		load	41	2182	274	565	271
		domInteractive	10	123	42	34	16

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-08-01T10:04:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-01T10:30:53Z

Builds ready [7e6b5d7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (266 ± 286 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	769	145	153	73
		domContentLoaded	9	176	32	41	19
		load	40	2363	266	595	286
		domInteractive	9	176	32	41	19

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 23 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: 🐛 use a counter to show if there are pending transactions

8a9b6aa

matteoscurati added the team-notifications Notifications team label Jul 25, 2024

Merge branch 'develop' into fix/use-counter-pending-transactions

08c707d

matteoscurati requested review from Prithpal-Sooriya and matthewwalsh0 July 25, 2024 08:24

Prithpal-Sooriya previously approved these changes Jul 25, 2024

View reviewed changes

matteoscurati marked this pull request as ready for review July 25, 2024 12:53

matteoscurati requested a review from a team as a code owner July 25, 2024 12:53

Merge branch 'develop' into fix/use-counter-pending-transactions

6e0d269

greptile-apps bot reviewed Jul 25, 2024

View reviewed changes

matthewwalsh0 requested changes Jul 25, 2024

View reviewed changes

app/scripts/background.js Outdated Show resolved Hide resolved

matteoscurati added 2 commits July 26, 2024 16:13

Merge branch 'develop' into fix/use-counter-pending-transactions

d0e995f

refactor: ♻️ the counter on the fox shows a maximum value of 9+

7a83fcb

matteoscurati dismissed Prithpal-Sooriya’s stale review via 7a83fcb July 26, 2024 14:27

matteoscurati requested review from matthewwalsh0 and Prithpal-Sooriya July 26, 2024 14:28

Merge branch 'develop' into fix/use-counter-pending-transactions

634bec5

Prithpal-Sooriya approved these changes Aug 1, 2024

View reviewed changes

matthewwalsh0 approved these changes Aug 1, 2024

View reviewed changes

Merge branch 'develop' into fix/use-counter-pending-transactions

7e6b5d7

Prithpal-Sooriya merged commit 82ad9c1 into develop Aug 1, 2024
75 checks passed

Prithpal-Sooriya deleted the fix/use-counter-pending-transactions branch August 1, 2024 11:06

github-actions bot locked and limited conversation to collaborators Aug 1, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 1, 2024

gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 🐛 use a counter to show if there are pending transactions #26116

fix: 🐛 use a counter to show if there are pending transactions #26116

matteoscurati commented Jul 25, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 25, 2024

matteoscurati commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 •

edited

Loading

greptile-apps bot left a comment

metamaskbot commented Jul 25, 2024

greptile-apps bot left a comment

metamaskbot commented Jul 26, 2024

metamaskbot commented Aug 1, 2024

sonarqubecloud bot commented Aug 1, 2024

metamaskbot commented Aug 1, 2024

fix: 🐛 use a counter to show if there are pending transactions #26116

fix: 🐛 use a counter to show if there are pending transactions #26116

Conversation

matteoscurati commented Jul 25, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 25, 2024

matteoscurati commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 • edited Loading

Codecov Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

metamaskbot commented Jul 25, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

metamaskbot commented Jul 26, 2024

metamaskbot commented Aug 1, 2024

sonarqubecloud bot commented Aug 1, 2024

Quality Gate passed

metamaskbot commented Aug 1, 2024

matteoscurati commented Jul 25, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 25, 2024 •

edited

Loading