chore: Upgrade core packages to release 159.0.0 #26138

cryptodev-2s · 2024-07-25T17:04:30Z

Upgrade core packages to release 159.0.0.

Upgraded packages:

@metamask/address-book-controller (4.0.2 -> 5.0.0)
@metamask/announcement-controller (6.1.0-> 7.0.0)
@metamask/base-controller (5.0.1 -> 6.0.2)
@metamask/message-manager (7.3.0 -> 10.0.0)
@metamask/notification-controller (5.0.1 -> 6.0.0)
@metamask/rate-limit-controller (5.0.1 -> 6.0.0)
@metamask/phishing-warning: (3.0.3 -> 4.0.0),
@metamask/build-utils (1.0.0 -> 3.0.0)

Description

Related issues

Fixes: #25401

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-25T17:04:45Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-07-25T17:05:43Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/helper-annotate-as-pure@7.24.7	None	`0`	52.4 kB	nicolo-ribaudo
npm/@babel/helper-replace-supers@7.24.7	None	`0`	98.6 kB	nicolo-ribaudo
npm/@babel/helper-skip-transparent-expression-wrappers@7.24.7	None	`0`	58.5 kB	nicolo-ribaudo
npm/@mantine/core@7.10.2	None	`0`	10.7 MB	rtivital
npm/@mantine/hooks@7.10.2	environment, network	`0`	1.02 MB	rtivital
npm/@metamask/address-book-controller@5.0.0	None	`0`	82.7 kB	metamaskbot
npm/@metamask/announcement-controller@7.0.0	None	`0`	76.2 kB	metamaskbot
npm/@metamask/build-utils@3.0.0	None	`0`	120 kB	metamaskbot
npm/@metamask/message-manager@10.0.2	None	`0`	288 kB	metamaskbot
npm/@metamask/notification-controller@6.0.0	None	`0`	78.9 kB	metamaskbot
npm/@metamask/phishing-warning@4.0.0	None	`0`	1.77 MB	danfinlay, gudahtt, kumavis, ...8 more
npm/@metamask/rate-limit-controller@6.0.0	None	`0`	93 kB	metamaskbot
npm/caniuse-lite@1.0.30001643	None	`0`	2.08 MB	caniuse-lite
npm/globalthis@1.0.3	None	`0`	22.4 kB	ljharb

🚮 Removed packages: npm/@babel/helper-annotate-as-pure@7.22.5), npm/@babel/helper-replace-supers@7.24.1), npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5), npm/@mantine/core@7.8.0), npm/@mantine/hooks@7.8.0), npm/@metamask/address-book-controller@4.0.1), npm/@metamask/announcement-controller@6.1.0), npm/@metamask/base-controller@5.0.2), npm/@metamask/build-utils@1.0.0), npm/@metamask/message-manager@7.3.9), npm/@metamask/notification-controller@5.0.2), npm/@metamask/phishing-warning@3.0.3), npm/@metamask/rate-limit-controller@5.0.1), npm/caniuse-lite@1.0.30001600), npm/escalade@3.1.1), npm/globalthis@1.0.1), npm/picocolors@1.0.0)

View full report↗︎

cryptodev-2s · 2024-07-25T17:07:05Z

@metamaskbot update-policies

metamaskbot · 2024-07-25T17:20:29Z

Policies updated

cryptodev-2s · 2024-07-30T12:59:50Z

@metamaskbot update-policies

.yarn/patches/@metamask-controller-utils-npm-8.0.4-077edd6162.patch

package.json

metamaskbot · 2024-07-30T13:13:17Z

Policies updated

MajorLift · 2024-07-31T15:26:35Z

Migrating json-rpc-engine to @metamask/json-rpc-engine has been previously attempted,

but postponed due to the possibility of breaking dapps:

Has this issue been resolved?

I believe eth-rpc-errors to @metamask/rpc-errors migration is a blocker for this, and that PR hasn't been merged yet.

fix(deps): update from eth-rpc-errors to @metamask/rpc-errors (cause edition) #24496

…packages-release-159

cryptodev-2s · 2024-08-01T14:39:14Z

@metamaskbot update-policies

metamaskbot · 2024-08-01T14:50:20Z

Policies updated

…packages-release-159

cryptodev-2s · 2024-08-04T10:58:58Z

@metamaskbot update-policies

cryptodev-2s · 2024-08-29T17:10:16Z

@metamaskbot update-policies

metamaskbot · 2024-08-29T17:21:33Z

Policies updated

codecov · 2024-08-29T17:42:05Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (be04ca8) to head (32ecf59).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
app/scripts/metamask-controller.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26138   +/-   ##
========================================
  Coverage    70.10%   70.10%           
========================================
  Files         1416     1416           
  Lines        49396    49396           
  Branches     13802    13802           
========================================
  Hits         34628    34628           
  Misses       14768    14768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-29T17:54:13Z

Builds ready [41070b2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1795 ± 75 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	227	2186	1721	375	180
		domContentLoaded	1599	2147	1772	149	72
		load	1612	2187	1795	156	75
		domInteractive	12	66	32	14	7

Bundle size diffs [🚀 Bundle size reduced!]

background: -164.82 KiB (-4.72%)
ui: 0 Bytes (0.00%)
common: -140.4 KiB (-1.71%)

app/scripts/lib/ppom/ppom-util.test.ts

app/scripts/lib/tx-verification/tx-verification-middleware.ts

metamaskbot · 2024-08-29T20:23:14Z

Builds ready [cc5b68e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1770 ± 119 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1528	2568	1774	246	118
		domContentLoaded	1494	2557	1739	246	118
		load	1502	2572	1770	248	119
		domInteractive	19	59	31	10	5

Bundle size diffs [🚀 Bundle size reduced!]

background: -164.82 KiB (-4.72%)
ui: 0 Bytes (0.00%)
common: -140.4 KiB (-1.71%)

…packages-release-159

cryptodev-2s · 2024-08-29T20:59:16Z

@metamaskbot update-policies

metamaskbot · 2024-08-29T21:10:35Z

Policies updated

sonarqubecloud · 2024-08-29T21:12:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-29T21:40:02Z

Builds ready [32ecf59]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1706 ± 76 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	256	2167	1575	466	224
		domContentLoaded	1548	2121	1691	153	74
		load	1556	2130	1706	158	76
		domInteractive	22	86	37	20	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -177.42 KiB (-5.07%)
ui: 0 Bytes (0.00%)
common: -140.4 KiB (-1.71%)

MajorLift · 2024-08-30T11:40:44Z

app/scripts/lib/snap-keyring/utils/isBlockedUrl.test.ts

@@ -10,7 +10,7 @@ describe('isBlockedUrl', () => {
    allowedEvents: [],
  });
  const phishingController = new PhishingController({
-    // @ts-expect-error TODO: Resolve/patch mismatch between messenger types
+    // @ts-expect-error TODO: Resolve mismatch between base-controller versions.


Note: @metamask/phishing-controller@12.0.1 is now on @metamask/base-controller@7.0.0, while the rest of extension is using @metamask/base-controller@6.0.2.

Yes exactly

MajorLift

LGTM!

montelaidev

Accounts changes LGTM

cryptodev-2s added the team-wallet-framework label Jul 25, 2024

cryptodev-2s requested a review from a team July 25, 2024 17:04

cryptodev-2s requested a review from a team as a code owner July 25, 2024 17:04

metamaskbot requested review from a team as code owners July 25, 2024 17:20

cryptodev-2s and others added 3 commits July 30, 2024 14:50

chore: Upgrade core packages to release 159.0.0

d361401

Update LavaMoat policies

053e967

fix: unit tests

977b628

cryptodev-2s force-pushed the chore/update-core-packages-release-159 branch from 803d024 to 977b628 Compare July 30, 2024 12:52

Gudahtt reviewed Jul 30, 2024

View reviewed changes

.yarn/patches/@metamask-controller-utils-npm-8.0.4-077edd6162.patch Outdated Show resolved Hide resolved

Gudahtt reviewed Jul 30, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update LavaMoat policies

08dc148

cryptodev-2s added 2 commits August 1, 2024 13:08

Merge remote-tracking branch 'origin/develop' into chore/update-core-…

21efc5e

…packages-release-159

Merge remote-tracking branch 'origin/develop' into chore/update-core-…

4ec2e6c

…packages-release-159

Update LavaMoat policies

a1e53c7

cryptodev-2s and others added 3 commits August 1, 2024 17:16

Merge branch 'develop' into chore/update-core-packages-release-159

05cd02a

fix: test lint issues

54040e6

Merge remote-tracking branch 'origin/develop' into chore/update-core-…

204d34b

…packages-release-159

cryptodev-2s and others added 2 commits August 4, 2024 13:03

fix: dedupe deps

1d06825

Update LavaMoat policies

9e1fbe3

fix: rollback phishing controller upgrade

dde3fae

Update LavaMoat policies

41070b2

cryptodev-2s requested a review from Gudahtt August 29, 2024 17:46

MajorLift reviewed Aug 29, 2024

View reviewed changes

app/scripts/lib/ppom/ppom-util.test.ts Outdated Show resolved Hide resolved

MajorLift reviewed Aug 29, 2024

View reviewed changes

app/scripts/lib/tx-verification/tx-verification-middleware.ts Outdated Show resolved Hide resolved

cryptodev-2s and others added 2 commits August 29, 2024 21:51

fix: reorganize type imports

1df9b74

Merge branch 'develop' into chore/update-core-packages-release-159

cc5b68e

Merge remote-tracking branch 'origin/develop' into chore/update-core-…

36f0bb3

…packages-release-159

cryptodev-2s and others added 2 commits August 29, 2024 23:01

fix: bypass origin instead of hostname

3c58788

Update LavaMoat policies

32ecf59

cryptodev-2s requested a review from MajorLift August 29, 2024 21:29

MajorLift reviewed Aug 30, 2024

View reviewed changes

MajorLift approved these changes Aug 30, 2024

View reviewed changes

Mrtenz approved these changes Aug 30, 2024

View reviewed changes

montelaidev approved these changes Aug 30, 2024

View reviewed changes

cryptodev-2s merged commit 5c34c85 into develop Aug 30, 2024
78 checks passed

cryptodev-2s deleted the chore/update-core-packages-release-159 branch August 30, 2024 12:05

github-actions bot locked and limited conversation to collaborators Aug 30, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Aug 30, 2024

gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Upgrade core packages to release 159.0.0 #26138

chore: Upgrade core packages to release 159.0.0 #26138

cryptodev-2s commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

socket-security bot commented Jul 25, 2024 •

edited

Loading

cryptodev-2s commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

cryptodev-2s commented Jul 30, 2024

metamaskbot commented Jul 30, 2024

MajorLift commented Jul 31, 2024

cryptodev-2s commented Aug 1, 2024

metamaskbot commented Aug 1, 2024

cryptodev-2s commented Aug 4, 2024

cryptodev-2s commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

codecov bot commented Aug 29, 2024 •

edited

Loading

metamaskbot commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

cryptodev-2s commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

sonarqubecloud bot commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

MajorLift Aug 30, 2024 •

edited

Loading

cryptodev-2s Aug 30, 2024

MajorLift left a comment

montelaidev left a comment

chore: Upgrade core packages to release 159.0.0 #26138

chore: Upgrade core packages to release 159.0.0 #26138

Conversation

cryptodev-2s commented Jul 25, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 25, 2024

socket-security bot commented Jul 25, 2024 • edited Loading

cryptodev-2s commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

cryptodev-2s commented Jul 30, 2024

metamaskbot commented Jul 30, 2024

MajorLift commented Jul 31, 2024

cryptodev-2s commented Aug 1, 2024

metamaskbot commented Aug 1, 2024

cryptodev-2s commented Aug 4, 2024

cryptodev-2s commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

codecov bot commented Aug 29, 2024 • edited Loading

Codecov Report

metamaskbot commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

cryptodev-2s commented Aug 29, 2024

metamaskbot commented Aug 29, 2024

sonarqubecloud bot commented Aug 29, 2024

Quality Gate passed

metamaskbot commented Aug 29, 2024

MajorLift Aug 30, 2024 • edited Loading

Choose a reason for hiding this comment

cryptodev-2s Aug 30, 2024

Choose a reason for hiding this comment

MajorLift left a comment

Choose a reason for hiding this comment

montelaidev left a comment

Choose a reason for hiding this comment

cryptodev-2s commented Jul 25, 2024 •

edited

Loading

socket-security bot commented Jul 25, 2024 •

edited

Loading

codecov bot commented Aug 29, 2024 •

edited

Loading

MajorLift Aug 30, 2024 •

edited

Loading