-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update BNB logos #26140
chore: update BNB logos #26140
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26140 +/- ##
===========================================
+ Coverage 67.31% 69.67% +2.36%
===========================================
Files 1266 1578 +312
Lines 49738 70867 +21129
Branches 12914 19705 +6791
===========================================
+ Hits 33478 49371 +15893
- Misses 16260 21496 +5236 ☔ View full report in Codecov by Sentry. |
Builds ready [ade0a57]
Page Load Metrics (54 ± 6 ms)
|
Builds ready [ade0a57]
Page Load Metrics (54 ± 6 ms)
|
Description
Updates BNB network logo to the newly provided png and svg assets.
Related issues
Fixes:
Manual testing steps
Load app and validate that BNB chain logos are updated. Note that erc20 token logos will not update until MetaMask/contract-metadata#1334 gets merged.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist