Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update BNB logos #26140

Merged
merged 1 commit into from
Jul 25, 2024
Merged

chore: update BNB logos #26140

merged 1 commit into from
Jul 25, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Jul 25, 2024

Description

Updates BNB network logo to the newly provided png and svg assets.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Load app and validate that BNB chain logos are updated. Note that erc20 token logos will not update until MetaMask/contract-metadata#1334 gets merged.

Screenshots/Recordings

Before

Screenshot 2024-07-25 at 10 20 48 AM Screenshot 2024-07-25 at 10 21 06 AM Screenshot 2024-07-25 at 10 22 32 AM Screenshot 2024-07-25 at 10 22 52 AM

After

Screenshot 2024-07-25 at 10 38 18 AM Screenshot 2024-07-25 at 10 38 59 AM Screenshot 2024-07-25 at 10 39 52 AM Screenshot 2024-07-25 at 10 40 15 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 25, 2024
@gambinish gambinish changed the title update bnb logos png and svg chore: update bnb logos png and svg Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish changed the title chore: update bnb logos png and svg chore: Update BNB logos Jul 25, 2024
@gambinish gambinish changed the title chore: Update BNB logos chore: update BNB logos Jul 25, 2024
@gambinish
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (0f11247) to head (ade0a57).
Report is 769 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26140      +/-   ##
===========================================
+ Coverage    67.31%   69.67%   +2.36%     
===========================================
  Files         1266     1578     +312     
  Lines        49738    70867   +21129     
  Branches     12914    19705    +6791     
===========================================
+ Hits         33478    49371   +15893     
- Misses       16260    21496    +5236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ade0a57]
Page Load Metrics (54 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6611989168
domContentLoaded9461784
load418954136
domInteractive9451784

@metamaskbot
Copy link
Collaborator

Builds ready [ade0a57]
Page Load Metrics (54 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6611989168
domContentLoaded9461784
load418954136
domInteractive9451784

@gambinish gambinish marked this pull request as ready for review July 25, 2024 18:55
@gambinish gambinish requested a review from a team as a code owner July 25, 2024 18:55
@gambinish gambinish requested a review from salimtb July 25, 2024 18:56
@gambinish gambinish merged commit b27dd2b into develop Jul 25, 2024
103 checks passed
@gambinish gambinish deleted the chore/update-bnb-logos branch July 25, 2024 22:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants