fix: improve performance in large signature request confirmations

[matthewwalsh0]

Description

Improve the performance when rendering large signature request confirmations.

After profiling within the browser, this appeared to ultimately be caused by the token list selectors which were firing repeatedly on the un-memoized token list, and in turn repeatedly converting it to a list and then comparing keys one at a time via a find.

This PR optimises those selectors using deep equal comparison and alternate selectors when the remote token list should always be used. In addition, case insensitive comparison should not be needed since both the remote and static token lists use lowercase addresses.

Related issues

Fixes: #26129

Manual testing steps

See issue.

Screenshots/Recordings

Before

legacy_before.mov

redesigned_before.mov

After

legacy_after.mov

redesigned_after.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (fe11329) to head (ec23860).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
ui/components/app/name/name.tsx	87.50%	3 Missing ⚠️
ui/components/app/confirm/info/row/address.tsx	92.31%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26209      +/-   ##
===========================================
- Coverage    69.98%   69.97%   -0.00%     
===========================================
  Files         1409     1409              
  Lines        49856    49849       -7     
  Branches     13779    13778       -1     
===========================================
- Hits         34887    34880       -7     
  Misses       14969    14969              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [ec23860]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (134 ± 151 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	125	93	18	9
		domContentLoaded	10	60	22	12	6
		load	42	1507	134	315	151
		domInteractive	10	60	22	12	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: 15 Bytes (0.00%)
• common: -188 Bytes (-0.00%)

[seaona]

I confirm I also see a massive improvement in both cases now 🔥

perf-fix-singatures.mp4