-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catch error for getTokenStandardAndDetails #26269
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2c587ed]
Page Load Metrics (550 ± 423 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26269 +/- ##
===========================================
- Coverage 70.09% 70.09% -0.00%
===========================================
Files 1413 1413
Lines 49254 49255 +1
Branches 13768 13768
===========================================
Hits 34524 34524
- Misses 14730 14731 +1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but leaving a curious comment
Builds ready [af18170]
Page Load Metrics (82 ± 23 ms)
Bundle size diffs
|
Description
Related to this reported Sentry error: https://metamask.sentry.io/issues/5660074561/?environment=production&project=273505&query=firstRelease%3A12.0.0&referrer=issue-stream&sort=freq&statsPeriod=90d&stream_index=22
Inside Import-nfts-modal.js we call
getTokenStandardAndDetails
without catching the case where this call fails.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-08-01.at.07.56.42.mov
After
Screen.Recording.2024-08-01.at.07.57.34.mov
Pre-merge author checklist
Pre-merge reviewer checklist