Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get permit and order signatures token decimals #26292

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented Aug 1, 2024

Description

Fix if clause to fetch token decimals for permit and order signatures.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptotavares cryptotavares requested a review from a team as a code owner August 1, 2024 16:30
Copy link
Contributor

github-actions bot commented Aug 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Aug 1, 2024
sleepytanya
sleepytanya previously approved these changes Aug 1, 2024
jpuri
jpuri previously approved these changes Aug 2, 2024
digiwand
digiwand previously approved these changes Aug 2, 2024
@cryptotavares cryptotavares force-pushed the cryptotavares/fix-getting-token-decimals-for-permit-and-order-typed-sign branch from ca7cf05 to 942eeff Compare August 2, 2024 14:56
Copy link

sonarqubecloud bot commented Aug 2, 2024

@digiwand digiwand requested review from jpuri and sleepytanya August 2, 2024 15:05
@metamaskbot
Copy link
Collaborator

Builds ready [942eeff]
Page Load Metrics (144 ± 154 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint723331116129
domContentLoaded11112282311
load461532144320154
domInteractive11112272311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (5b56034) to head (942eeff).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26292   +/-   ##
========================================
  Coverage    70.04%   70.04%           
========================================
  Files         1411     1411           
  Lines        50031    50031           
  Branches     13812    13812           
========================================
+ Hits         35042    35044    +2     
+ Misses       14989    14987    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cryptotavares cryptotavares merged commit 2a39edf into develop Aug 2, 2024
75 checks passed
@cryptotavares cryptotavares deleted the cryptotavares/fix-getting-token-decimals-for-permit-and-order-typed-sign branch August 2, 2024 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 2, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants