-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add guard for draft tx in send validation #26295
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26295 +/- ##
========================================
Coverage 69.99% 70.00%
========================================
Files 1410 1410
Lines 49958 49964 +6
Branches 13798 13801 +3
========================================
+ Hits 34968 34974 +6
Misses 14990 14990 ☔ View full report in Codecov by Sentry. |
Builds ready [75e6c33]
Page Load Metrics (413 ± 389 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
0d499e3
to
bb906c0
Compare
Quality Gate passedIssues Measures |
Builds ready [bb906c0]
Page Load Metrics (150 ± 174 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
We have discovered a sentry error for the swaps flow in extension:
https://metamask.sentry.io/issues/5659965775/?environment=production&project=273505&query=firstRelease%3A12.0.0&referrer=issue-stream&sort=freq&statsPeriod=90d&stream_index=17
This error is due to the
draftTransaction
not being defined during validation; this is resolved with an undefined guard. This error appears in other actions; it is resolved in these cases as well.Related issues
Fixes:
Manual testing steps
state.draftTransactions[state.currentTransactionUUID]
toundefined
inducks/send/send.js
for all selectorsScreenshots/Recordings
Before
Screen.Recording.2024-08-01.at.4.37.55.PM.mov
After
Screen.Recording.2024-08-01.at.4.15.57.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist