Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove obsolete NetworkController state #26302

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 1, 2024

Description

Migration 120.2 has been updated to remove obsolete NetworkController state as well.

Open in GitHub Codespaces

Related issues

Fixes #26297

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 1, 2024

Blocked by #26298

Base automatically changed from refactor-migration-120.2 to develop August 2, 2024 11:24
@Gudahtt Gudahtt force-pushed the remove-obsolete-network-controller-state branch from 6110994 to b2ea75d Compare August 2, 2024 11:24
@Gudahtt Gudahtt marked this pull request as ready for review August 2, 2024 11:29
@Gudahtt Gudahtt requested a review from a team as a code owner August 2, 2024 11:29
Migration 120.2 has been updated to remove obsolete NetworkController
state as well.

Fixes #26297
@Gudahtt Gudahtt force-pushed the remove-obsolete-network-controller-state branch from b2ea75d to c17e849 Compare August 2, 2024 11:38
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (b22e018) to head (c17e849).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26302      +/-   ##
===========================================
+ Coverage    70.02%   70.03%   +0.01%     
===========================================
  Files         1411     1411              
  Lines        49995    50008      +13     
  Branches     13805    13807       +2     
===========================================
+ Hits         35006    35019      +13     
  Misses       14989    14989              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [c17e849]
Page Load Metrics (311 ± 267 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint863221356330
domContentLoaded11160313215
load491726311556267
domInteractive11160313215
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 396 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt added team-extension-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Aug 2, 2024
@Gudahtt Gudahtt force-pushed the remove-obsolete-network-controller-state branch from cc38f47 to c17e849 Compare August 2, 2024 13:00
Copy link

sonarqubecloud bot commented Aug 2, 2024

Copy link
Contributor

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 69e57d8 into develop Aug 2, 2024
98 checks passed
@Gudahtt Gudahtt deleted the remove-obsolete-network-controller-state branch August 2, 2024 13:15
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Aug 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 2, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-extension-platform team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Error: No metadata found for 'networkStatus'
5 participants