fix: issue where setNetworkClientIdForDomain was called without checking whether the origin was eligible for setting its own network

[adonesky1]

Description

This PR fixes a issue where setNetworkClientIdForDomain was frequently called with origins that had no account permissions yet (which is the thresshold we currently set for giving site's their own network) resulting in a large number of silent errors in the background that are clogging up sentry.

Related issues

Fixes: https://metamask.sentry.io/issues/5659582204/?environment=production&project=273505&qu%5B%E2%80%A6%5Derrer=issue-stream&sort=freq&statsPeriod=90d&stream_index=1

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Gudahtt]

LGTM!

[jiexi]

not sure how important this is, but somewhere else in code i saw setNetworkClientIdForDomain guarded by hasPermissions instead of checking if the origin has a networkClientId set. The controller itself checks hasPermissions.

[adonesky1]

These should always be in sync and perhaps we should change the controller to look at domains state since the state of which permissions are the threshhold may change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.05%. Comparing base (5b56034) to head (5a94d97).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26323      +/-   ##
===========================================
+ Coverage    70.04%   70.05%   +0.01%     
===========================================
  Files         1411     1411              
  Lines        50031    50035       +4     
  Branches     13812    13815       +3     
===========================================
+ Hits         35042    35048       +6     
+ Misses       14989    14987       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [5a94d97]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (291 ± 262 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	59	315	113	64	31
		domContentLoaded	9	154	33	37	18
		load	38	1764	291	545	262
		domInteractive	9	154	33	37	18

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 45 Bytes (0.00%)
• common: 0 Bytes (0.00%)