Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add contract deployment redesigned transaction screen #26382

Merged
merged 10 commits into from
Aug 22, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Aug 13, 2024

Description

Introduces new contract deployment screen. Includes end to end test.

Open in GitHub Codespaces

Related issues

Fixes: 2874

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Aug 13, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Aug 13, 2024
@pedronfigueiredo pedronfigueiredo requested review from a team as code owners August 13, 2024 09:43
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/2874 branch 2 times, most recently from 3dc5edc to 8bc5a94 Compare August 14, 2024 08:58
digiwand
digiwand previously approved these changes Aug 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [8e76c44]
Page Load Metrics (77 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint631521052612
domContentLoaded3911173209
load4511277189
domInteractive94927115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 174 Bytes (0.00%)

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (ab79f0d) to head (ea87a5a).
Report is 6 commits behind head on develop.

Files Patch % Lines
...s/confirmations/components/confirm/title/title.tsx 0.00% 4 Missing ⚠️
...ges/confirmations/components/confirm/info/info.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26382      +/-   ##
===========================================
- Coverage    70.02%   70.01%   -0.01%     
===========================================
  Files         1408     1408              
  Lines        49105    49110       +5     
  Branches     13735    13737       +2     
===========================================
  Hits         34383    34383              
- Misses       14722    14727       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jpuri
jpuri previously approved these changes Aug 20, 2024
matthewwalsh0
matthewwalsh0 previously approved these changes Aug 21, 2024
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [ea87a5a]
Page Load Metrics (72 ± 7 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint761571002211
domContentLoaded4811268168
load5511272157
domInteractive176729126
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 217 Bytes (0.00%)
  • common: 174 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 8f8a0ba into develop Aug 22, 2024
78 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/2874 branch August 22, 2024 09:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 22, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants