-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove double padding on Snap home page #26462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamaskbot
added
INVALID-PR-TEMPLATE
PR's body doesn't match template
team-snaps-platform
Snaps Platform team
labels
Aug 16, 2024
david0xd
previously approved these changes
Aug 16, 2024
Builds ready [b894e88]
Page Load Metrics (190 ± 205 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26462 +/- ##
========================================
Coverage 70.12% 70.12%
========================================
Files 1428 1428
Lines 50089 50089
Branches 13894 13894
========================================
Hits 35120 35120
Misses 14969 14969 ☔ View full report in Codecov by Sentry. |
david0xd
approved these changes
Aug 16, 2024
Quality Gate passedIssues Measures |
Builds ready [45e4ee4]
Page Load Metrics (152 ± 165 ms)
Bundle size diffs
|
Mrtenz
approved these changes
Aug 16, 2024
metamaskbot
added
the
release-12.5.0
Issue or pull request that will be included in release 12.5.0
label
Aug 16, 2024
gauthierpetetin
added
release-12.4.0
Issue or pull request that will be included in release 12.4.0
and removed
release-12.5.0
Issue or pull request that will be included in release 12.5.0
labels
Sep 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.4.0
Issue or pull request that will be included in release 12.4.0
team-snaps-platform
Snaps Platform team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a newly introduced issue where the Snap home page would have double padding since all Snap UI's are wrapped in
<Container>
as of f461e37, the container component adds 16px of padding by itself.