Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove double padding on Snap home page #26462

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Aug 16, 2024

Description

Fixes a newly introduced issue where the Snap home page would have double padding since all Snap UI's are wrapped in <Container> as of f461e37, the container component adds 16px of padding by itself.

Open in GitHub Codespaces

@FrederikBolding FrederikBolding requested a review from a team as a code owner August 16, 2024 08:56
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Aug 16, 2024
david0xd
david0xd previously approved these changes Aug 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b894e88]
Page Load Metrics (190 ± 205 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint782981224622
domContentLoaded118534199
load452047190427205
domInteractive118534199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 14 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (2d63c0e) to head (45e4ee4).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26462   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1428     1428           
  Lines        50089    50089           
  Branches     13894    13894           
========================================
  Hits         35120    35120           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [45e4ee4]
Page Load Metrics (152 ± 165 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint71136102178
domContentLoaded107427157
load421652152345165
domInteractive107427157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 14 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 211cf40 into develop Aug 16, 2024
78 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snap-home-padding branch August 16, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 16, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants