-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jl/caip multichain/misc cleanup #26724
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
// if (scopeStringA !== scopeStringB) { | ||
// throw new Error('cannot merge ScopeObjects for different ScopeStrings') | ||
// } | ||
|
||
// TODO: Should we be verifying that these scopeStrings are flattened / the scopeObjects do not contain `scopes` array? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we do this in the mergeScopes
function? Can this TODO be removed as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i removed this comment in a separate open PR, but it won't hurt to remove it in this one too, and so we shall 🙏
Description
Misc cleanup. Removing
KnownCaipNamespace
is still not possible because@metamask/util
does not have aWallet
enum valueRelated issues
See: https://github.com/MetaMask/MetaMask-planning/issues/3050
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist