Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/caip multichain/misc cleanup #26724

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Aug 28, 2024

Description

Misc cleanup. Removing KnownCaipNamespace is still not possible because @metamask/util does not have a Wallet enum value

Open in GitHub Codespaces

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/3050

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

// if (scopeStringA !== scopeStringB) {
// throw new Error('cannot merge ScopeObjects for different ScopeStrings')
// }

// TODO: Should we be verifying that these scopeStrings are flattened / the scopeObjects do not contain `scopes` array?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we do this in the mergeScopes function? Can this TODO be removed as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed this comment in a separate open PR, but it won't hurt to remove it in this one too, and so we shall 🙏

@jiexi jiexi marked this pull request as ready for review August 28, 2024 21:58
@jiexi jiexi requested a review from a team as a code owner August 28, 2024 21:58
@jiexi jiexi merged commit 9fb5fed into caip-multichain Aug 28, 2024
62 of 68 checks passed
@jiexi jiexi deleted the jl/caip-multichain/misc-cleanup branch August 28, 2024 21:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants