Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/caip multichain/replace known caip namespace with metamask utils #26765

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Aug 29, 2024

Description

Replaces our internal KnownCaipNamespaces enum with one that was added in @metamask/utils 9.2.0, but is patched into 8.5.1 on this branch

Open in GitHub Codespaces

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/3050

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@metamask/utils@8.5.0), npm/@types/debug@4.1.7), npm/@types/ms@0.7.31), npm/pony-cause@2.1.10)

View full report↗︎

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiexi jiexi marked this pull request as ready for review September 3, 2024 17:54
@jiexi jiexi requested a review from a team as a code owner September 3, 2024 17:54
@jiexi jiexi merged commit aa92005 into caip-multichain Sep 3, 2024
14 of 16 checks passed
@jiexi jiexi deleted the jl/caip-multichain/replace-KnownCaipNamespace-with-metamask-utils branch September 3, 2024 17:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants