Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: celebratory update of yarn to v4.4.1 #26775

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

HowardBraham
Copy link
Contributor

@HowardBraham HowardBraham commented Aug 29, 2024

Description

To celebrate the @Gudahtt contribution to yarn berry v4.4.1, we're updating our yarn!

Updates:

  1. Yarn to celebratory v4.4.1
  2. Node to v20.17 (the bug locking us to v20.14 was fixed here)
  3. CircleCI cimg to Node v20.17
  4. CircleCI ubuntu to ubuntu-2404:current (all of our GitHub Actions are already using ubuntu-latest, and I don't think there's a good reason to lock to a specific release of ubuntu-2404)

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Aug 29, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [872f89b]
Page Load Metrics (1661 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14572216167420297
domContentLoaded14402123163817885
load14482213166119192
domInteractive126330136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (11f4a57) to head (872f89b).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26775   +/-   ##
========================================
  Coverage    70.08%   70.08%           
========================================
  Files         1414     1414           
  Lines        49330    49330           
  Branches     13782    13782           
========================================
  Hits         34570    34570           
  Misses       14760    14760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru self-requested a review August 29, 2024 23:20
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HowardBraham HowardBraham merged commit b82f5b4 into develop Aug 30, 2024
86 checks passed
@HowardBraham HowardBraham deleted the yarn-4.4.1 branch August 30, 2024 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Aug 30, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@HowardBraham HowardBraham added contributor experience An issue that impacts, or planned improvement to, the contributor experience. and removed team-contributor-experience labels Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants