Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MMI adds mmi flow to new transactions confirmations view #26817

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

zone-live
Copy link
Contributor

Description

The MMI tx flow is working again, we were missing the support for the new redesign of the transactions confirmation UI.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested review from a team as code owners August 30, 2024 14:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-mmi PRs from the MMI team label Aug 30, 2024
albertolive
albertolive previously approved these changes Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.13%. Comparing base (e239d85) to head (14d56e7).

Files with missing lines Patch % Lines
ui/hooks/useMMICustodySendTransaction.ts 88.00% 3 Missing ⚠️
ui/hooks/useMMIConfirmations.ts 50.00% 1 Missing ⚠️
...confirmations/components/confirm/footer/footer.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26817      +/-   ##
===========================================
+ Coverage    70.12%   70.13%   +0.01%     
===========================================
  Files         1422     1423       +1     
  Lines        49526    49554      +28     
  Branches     13863    13866       +3     
===========================================
+ Hits         34730    34753      +23     
- Misses       14796    14801       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [14d56e7]
Page Load Metrics (1910 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25525271754552265
domContentLoaded154125191888257123
load154925331910259124
domInteractive15121402612
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 9c24dac into develop Sep 3, 2024
78 checks passed
@zone-live zone-live deleted the MMI-5388-add-mmi-flow-to-new-confirmations-view branch September 3, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 3, 2024
@gauthierpetetin gauthierpetetin added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 11, 2024
@gauthierpetetin gauthierpetetin removed the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants