Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirmation screen with in expanded extension view #26965

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 6, 2024

Description

Fix width of confirmation pages in expanded view.

Related issues

Fixes: #26937

Manual testing steps

  1. Go to test dapp
  2. Submit signature
  3. Open signature in expanded view - it should have small page width

Screenshots/Recordings

Screenshot 2024-09-06 at 5 03 29 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 6, 2024
@jpuri jpuri requested a review from a team as a code owner September 6, 2024 11:35
Copy link
Contributor

github-actions bot commented Sep 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@@ -4,6 +4,6 @@
box-shadow: var(--shadow-size-lg) var(--color-shadow-default);

@media screen and (min-width: design-system.$break-small) {
max-width: 62%;
max-width: 360px;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (8ffbb54) to head (e443374).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26965   +/-   ##
========================================
  Coverage    70.17%   70.17%           
========================================
  Files         1425     1425           
  Lines        49647    49647           
  Branches     13889    13889           
========================================
  Hits         34836    34836           
  Misses       14811    14811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [e443374]
Page Load Metrics (2028 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34126021945476229
domContentLoaded164124862004277133
load165426062028288138
domInteractive13150453416
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit abdf6a8 into develop Sep 6, 2024
84 checks passed
@jpuri jpuri deleted the redesigned_fullscreen_width_fix branch September 6, 2024 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 6, 2024
@digiwand
Copy link
Contributor

digiwand commented Sep 6, 2024

Hello @jpuri! I'm unsure this is the final, intended design for our redesign confirmations. Can we confirm this with design?
cc: @SayaGT

A couple of concerns:

  • Although 360px is used for the figma design, I wonder if it was designed to be the max-width of the UI. 360px is smaller than the original confirmation width 408px
  • The height extends to the full height of the display. This can introduce more empty space (please see images below). The other

Current non-redesign transaction screen:

CleanShot 2024-09-06 at 12 13 34@2x

Current redesign confirmations, after this PR has been merged:

CleanShot 2024-09-06 at 12 11 35@2x
CleanShot 2024-09-06 at 12 12 25@2x
CleanShot 2024-09-06 at 12 13 09@2x
CleanShot 2024-09-06 at 12 13 59@2x

@digiwand
Copy link
Contributor

digiwand commented Sep 6, 2024

another design inquiry is the padding on top and bottom. In full-screen mode, there is padding on top whereas below there is no padding. What would be the desired padding here?

CleanShot 2024-09-06 at 15 35 13@2x
CleanShot 2024-09-06 at 15 35 21@2x

@digiwand
Copy link
Contributor

digiwand commented Sep 9, 2024

before screenshot:

CleanShot 2024-09-05 at 14 54 31 2@2x

@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Signature request has different UI on Expanded view
6 participants