-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: confirmation screen with in expanded extension view #26965
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -4,6 +4,6 @@ | |||
box-shadow: var(--shadow-size-lg) var(--color-shadow-default); | |||
|
|||
@media screen and (min-width: design-system.$break-small) { | |||
max-width: 62%; | |||
max-width: 360px; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value 360px is taken from figma designs https://www.figma.com/design/H52Ob2wDWsPY4g9DeYuCLk/Confirmation-redesign-V6?node-id=3433-27766&node-type=FRAME&t=N7Ij9OuBbvoIlqrJ-0
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26965 +/- ##
========================================
Coverage 70.17% 70.17%
========================================
Files 1425 1425
Lines 49647 49647
Branches 13889 13889
========================================
Hits 34836 34836
Misses 14811 14811 ☔ View full report in Codecov by Sentry. |
Builds ready [e443374]
Page Load Metrics (2028 ± 138 ms)
Bundle size diffs
|
Hello @jpuri! I'm unsure this is the final, intended design for our redesign confirmations. Can we confirm this with design? A couple of concerns:
Current non-redesign transaction screen:Current redesign confirmations, after this PR has been merged: |
Description
Fix width of confirmation pages in expanded view.
Related issues
Fixes: #26937
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist