fix: Don't show third party notice for preinstalled Snaps

[Mrtenz]

Description

We show a third party notice when installing or connecting to a Snap for the first time. Preinstalled Snaps are first party Snaps however, so we don't need to show the warning for these Snaps. I've implemented some logic that checks if the requested Snap is a preinstalled Snap, and only show the third party notice if it's not.

Related issues

Fixes: MetaMask/MetaMask-planning#3325.

Manual testing steps

Assuming you have not accepted the third party notice before:

1. Go to the Test Snaps page
2. Connect to the preinstalled Snap, and verify the notice is not shown
3. Connect to any other Snap, and verify that the notice is shown

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[sonarqubecloud]

Quality Gate failed

Failed conditions
7.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[metamaskbot]

Builds ready [78ee5b7]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1505 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1398	1927	1516	115	55
		domContentLoaded	1390	1846	1484	105	50
		load	1397	1933	1505	118	57
		domInteractive	17	81	28	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 Bytes (0.00%)
• ui: 70 Bytes (0.00%)
• common: 156 Bytes (0.00%)

[legobeat]

Maybe this would benefit from a test-case or two?

[Mrtenz]

Maybe this would benefit from a test-case or two?

It certainly would, but I'm trying to get it cherry-picked ASAP and the entire component is untested 😞

[FrederikBolding]

Seems like this would make us skip the third party notice if multiple Snaps are installed where one is preinstalled? That seems wrong to me 🤔