-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Display setApprovalForAll and revoke setApprovalForAll to users… #27401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [a84a280]
Page Load Metrics (1895 ± 104 ms)
Bundle size diffs
|
vinistevam
previously approved these changes
Sep 26, 2024
jpuri
previously approved these changes
Sep 26, 2024
pedronfigueiredo
dismissed stale reviews from jpuri and vinistevam
via
September 26, 2024 13:23
c92983d
pedronfigueiredo
force-pushed
the
pnf/show-set-approval-for-all
branch
from
September 26, 2024 13:23
a84a280
to
c92983d
Compare
Builds ready [c92983d]
Page Load Metrics (1783 ± 95 ms)
Bundle size diffs
|
pedronfigueiredo
force-pushed
the
pnf/show-set-approval-for-all
branch
from
September 26, 2024 14:22
c92983d
to
3d941eb
Compare
Quality Gate passedIssues Measures |
Builds ready [3d941eb]
Page Load Metrics (1714 ± 65 ms)
Bundle size diffs
|
jpuri
approved these changes
Sep 26, 2024
vinistevam
approved these changes
Sep 26, 2024
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Sep 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… that opt in
Description
This makes both redesigned screens available for users that opt into redesigned transaction screens in the experimental settings page.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist