-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change speed key color #27416
fix: Change speed key color #27416
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @pedronfigueiredo, nice fix! This PR does require snapshot updates
ui/pages/confirmations/components/confirm/info/set-approval-for-all-info/set-approval-for-all-info.test.tsx
Builds ready [289c1da]
Page Load Metrics (2218 ± 242 ms)
Bundle size diffs
|
289c1da
to
ff65152
Compare
Quality Gate passedIssues Measures |
Builds ready [ff65152]
Page Load Metrics (1693 ± 94 ms)
Bundle size diffs
|
Description
As part of #26986, the wrapper component for "Speed" was changed from ConfirmInfoRow to ConfirmInfoAlertRow. This change means that the
ConfirmInfoRowVariant.Default
applied to this component changes the color to blue.To revert that aesthetic change, this PR removes said variant.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist