Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change speed key color #27416

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 26, 2024

Description

As part of #26986, the wrapper component for "Speed" was changed from ConfirmInfoRow to ConfirmInfoAlertRow. This change means that the ConfirmInfoRowVariant.Default applied to this component changes the color to blue.

To revert that aesthetic change, this PR removes said variant.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screenshot 2024-09-26 at 10 57 44

After

Screenshot 2024-09-26 at 10 56 03

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 26, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 26, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner September 26, 2024 10:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

jpuri
jpuri previously approved these changes Sep 26, 2024
Copy link
Contributor

@digiwand digiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @pedronfigueiredo, nice fix! This PR does require snapshot updates

ui/pages/confirmations/components/confirm/info/set-approval-for-all-info/set-approval-for-all-info.test.tsx

CleanShot 2024-09-26 at 18 11 04@2x

@digiwand
Copy link
Contributor

plus 1 lint error has appeared

CleanShot 2024-09-26 at 18 13 23@2x

@metamaskbot
Copy link
Collaborator

Builds ready [289c1da]
Page Load Metrics (2218 ± 242 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint79634102116563270
domContentLoaded149233672190492236
load149934872218505242
domInteractive18157583517
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -224 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo force-pushed the pnf/change-speed-key-color branch from 289c1da to ff65152 Compare September 26, 2024 14:23
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [ff65152]
Page Load Metrics (1693 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24721881632367176
domContentLoaded14112173166719292
load14142189169319694
domInteractive23197584723
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -224 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo merged commit 4fbb0ea into develop Sep 26, 2024
77 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/change-speed-key-color branch September 26, 2024 17:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants