Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps): Connect getCurrencyRate hook to multichainRateController #27489

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Sep 30, 2024

Description

This PR connects the getCurrencyRate hook used in snap_getCurrencyRate permitted RPC method.

Open in GitHub Codespaces

Related issues

Fixes: MetaMask/snaps#2762

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested review from a team as code owners September 30, 2024 10:11
@GuillaumeRx GuillaumeRx changed the base branch from develop to mrtenz/bump-snaps-packages September 30, 2024 10:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 30, 2024
@GuillaumeRx GuillaumeRx merged commit 306d898 into mrtenz/bump-snaps-packages Oct 2, 2024
65 of 68 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/add-get-currency-rate branch October 2, 2024 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create snap_getRate RPC method
2 participants