Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add different copy for tooltip when a snap is requesting a signature #27492

Merged
merged 16 commits into from
Nov 4, 2024
Merged

fix: Add different copy for tooltip when a snap is requesting a signature #27492

merged 16 commits into from
Nov 4, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Sep 30, 2024 •
edited
Loading

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? The tooltip content incorrectly says "site" when a snap is requesting a signature
  2. What is the improvement/solution? Changing the copy to say "snap" for when a snap is making the signature request.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 30, 2024
@hmalik88 hmalik88 marked this pull request as ready for review September 30, 2024 13:29
@hmalik88 hmalik88 requested review from a team as code owners September 30, 2024 13:29
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 30, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [38867f3]
Page Load Metrics (1665 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14912090167115775
domContentLoaded14832001163112660
load14912101166514469
domInteractive23121422512
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 657 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [00059d0]
Page Load Metrics (1863 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22923201718518249
domContentLoaded16112245184216981
load16602257186317684
domInteractive1899432010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 657 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

FrederikBolding
FrederikBolding previously approved these changes Oct 1, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [db686a2]
Page Load Metrics (1908 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint159023861906220106
domContentLoaded157723141874211101
load159623831908226109
domInteractive2688452110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 657 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

Mrtenz
Mrtenz previously approved these changes Oct 6, 2024
View reviewed changes
@hmalik88 hmalik88 dismissed stale reviews from Mrtenz and FrederikBolding via d8ab51d October 28, 2024 22:10
@metamaskbot
Copy link
Collaborator

Builds ready [d8ab51d]
Page Load Metrics (2112 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38927342000423203
domContentLoaded178626452080235113
load179526972112233112
domInteractive288758178
backgroundConnect962292010
firstReactRender982041232512
getState56320209
initialActions01000
loadScripts127520331525208100
setupStore1178262210
uiStartup201132402378293141
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 633 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

Mrtenz
Mrtenz previously approved these changes Oct 29, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [9de766e]
Page Load Metrics (1936 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint168427881942258124
domContentLoaded167027161914246118
load168127821936253121
domInteractive23109522110
backgroundConnect115622147
firstReactRender46174922713
getState54814146
initialActions01000
loadScripts12392039142620799
setupStore1163272010
uiStartup187430062133269129
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 633 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [13b2949]
Page Load Metrics (1892 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint34125321746457219
domContentLoaded161624371864239115
load162425361892246118
domInteractive22182583617
backgroundConnect797252512
firstReactRender4710683199
getState46114168
initialActions01000
loadScripts11771825138919995
setupStore1165242010
uiStartup183527302070247119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 633 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

jpuri
jpuri reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, it will be nice to have some unit test coverage also, something we try to do for all confirmation code.

@hmalik88 hmalik88 dismissed stale reviews from Mrtenz and FrederikBolding via 14765e8 November 4, 2024 11:00
Mrtenz
Mrtenz previously approved these changes Nov 4, 2024
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [50e864f]
Page Load Metrics (1953 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint161824011964212102
domContentLoaded160023881929213102
load161124061953213102
domInteractive18142542813
backgroundConnect9110252411
firstReactRender46183983517
getState458232211
initialActions01000
loadScripts11291761144016881
setupStore1168332311
uiStartup176927202163236113
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 633 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

FrederikBolding
FrederikBolding previously approved these changes Nov 4, 2024
View reviewed changes
@hmalik88 hmalik88 dismissed stale reviews from FrederikBolding and Mrtenz via 47ffbf8 November 4, 2024 12:22
@metamaskbot
Copy link
Collaborator

Builds ready [47ffbf8]
Page Load Metrics (2299 ± 137 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint198629742300287138
domContentLoaded196629452259284136
load198929532299284137
domInteractive178947178
backgroundConnect9144393517
firstReactRender642781134622
getState7107343014
initialActions01000
loadScripts141122791665214103
setupStore12102352713
uiStartup221936262552341164
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 633 Bytes (0.01%)
  • common: 76 Bytes (0.00%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit 7a8da64 Nov 4, 2024
76 checks passed
@FrederikBolding FrederikBolding deleted the hm/fix-copy branch November 4, 2024 14:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@jpuri jpuri jpuri approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-snaps-platform Snaps Platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmalik88 @metamaskbot @FrederikBolding @jpuri @Mrtenz