fix: Gracefully handle bad responses from `net_version` calls to RPC endpoint when getting Provider Network State #27509

jiexi · 2024-09-30T18:05:56Z

Description

Currently some users are seeing Error: Cannot parse as a valid network ID: 'undefined' errors when connected to RPC endpoints that fail to provide a value from net_version calls that can be parsed into a decimal string. This PR makes our internally handling of this case more flexibly by using null as the network version value sent to the inpage provider when receiving an unexpected net_version call value.

Related issues

Fixes: #27487

Manual testing steps

Open extension background
Intercept a request for net_version (you can use a proxy like Burpsuite) and make it return a bad value
There should be no error in extension background related to this
Open a dapp
Open the dapp developer console
Expect to see an error like JsonRpcError: MetaMask: Disconnected from chain. Attempting to connect.
Test that window.ethereum.request works as expected despite this

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… value

github-actions · 2024-09-30T18:06:09Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-30T18:40:10Z

Builds ready [3d4a7e2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1680 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1543	2328	1682	162	78
		domContentLoaded	1467	2316	1664	166	80
		load	1475	2336	1680	168	80
		domInteractive	24	202	58	47	23

Bundle size diffs [🚀 Bundle size reduced!]

background: 11 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -41 Bytes (-0.00%)

…-error

sonarqubecloud · 2024-10-04T15:48:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-04T16:12:41Z

Builds ready [5e7f833]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1846 ± 128 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1548	2879	1845	277	133
		domContentLoaded	1541	2813	1829	267	128
		load	1548	2820	1846	266	128
		domInteractive	26	96	54	22	11

Bundle size diffs [🚀 Bundle size reduced!]

background: 11 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -41 Bytes (-0.00%)

…-error

hjetpoluru

LGTM

…-error

metamaskbot · 2024-10-21T19:36:43Z

Builds ready [5165b03]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1768 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1571	2335	1768	172	83
		domContentLoaded	1562	2175	1731	152	73
		load	1570	2415	1768	187	90
		domInteractive	20	172	52	36	17
		backgroundConnect	9	230	37	49	24
		firstReactRender	42	194	90	38	18
		getState	5	93	29	28	13
		initialActions	0	1	0	0	0
		loadScripts	1169	1649	1289	125	60
		setupStore	10	96	28	24	11
		uiStartup	1721	3321	2007	327	157

Bundle size diffs [🚀 Bundle size reduced!]

background: 11 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -41 Bytes (-0.00%)

Gudahtt

LGTM!

…-error

metamaskbot · 2024-11-20T23:56:32Z

Builds ready [19060cc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2062 ± 108 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	407	2456	1978	423	203
		domContentLoaded	1601	2375	2029	215	103
		load	1611	2464	2062	224	108
		domInteractive	17	178	50	33	16
		backgroundConnect	10	88	33	26	12
		firstReactRender	66	221	99	40	19
		getState	51	202	96	38	18
		initialActions	0	1	0	0	0
		loadScripts	1163	1835	1532	184	88
		setupStore	7	82	15	19	9
		uiStartup	1926	3300	2407	305	146

Bundle size diffs [🚀 Bundle size reduced!]

background: 11 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -41 Bytes (-0.00%)

jiexi added 2 commits September 30, 2024 10:57

Update convertNetworkId to return null. Add spec

082d7e5

Do not try to resolve net_version if we already tried but got invalid…

3d4a7e2

… value

github-actions bot added the team-wallet-api-platform label Sep 30, 2024

jiexi marked this pull request as ready for review September 30, 2024 18:07

jiexi requested a review from a team as a code owner September 30, 2024 18:07

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

5e7f833

…-error

jiexi and others added 2 commits October 9, 2024 09:44

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

86c9118

…-error

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

77b5eff

…-error

hjetpoluru approved these changes Oct 19, 2024

View reviewed changes

legobeat requested a review from a team October 21, 2024 19:00

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

5165b03

…-error

Gudahtt approved these changes Nov 1, 2024

View reviewed changes

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

5434b4e

…-error

jiexi enabled auto-merge November 19, 2024 18:34

jiexi added 3 commits November 19, 2024 14:33

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

622ce7b

…-error

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

9f73156

…-error

Merge branch 'develop' into jl/mme-27487/fix-net_version-bad-response…

19060cc

…-error

jiexi added this pull request to the merge queue Nov 20, 2024

Merged via the queue into develop with commit 1975c85 Nov 21, 2024
75 checks passed

jiexi deleted the jl/mme-27487/fix-net_version-bad-response-error branch November 21, 2024 00:06

github-actions bot locked and limited conversation to collaborators Nov 21, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Gracefully handle bad responses from `net_version` calls to RPC endpoint when getting Provider Network State #27509

fix: Gracefully handle bad responses from `net_version` calls to RPC endpoint when getting Provider Network State #27509

jiexi commented Sep 30, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Sep 30, 2024

metamaskbot commented Sep 30, 2024

sonarqubecloud bot commented Oct 4, 2024

metamaskbot commented Oct 4, 2024

hjetpoluru left a comment

metamaskbot commented Oct 21, 2024

Gudahtt left a comment

metamaskbot commented Nov 20, 2024

fix: Gracefully handle bad responses from net_version calls to RPC endpoint when getting Provider Network State #27509

fix: Gracefully handle bad responses from net_version calls to RPC endpoint when getting Provider Network State #27509

Conversation

jiexi commented Sep 30, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 30, 2024

metamaskbot commented Sep 30, 2024

sonarqubecloud bot commented Oct 4, 2024

Quality Gate passed

metamaskbot commented Oct 4, 2024

hjetpoluru left a comment

Choose a reason for hiding this comment

metamaskbot commented Oct 21, 2024

Gudahtt left a comment

Choose a reason for hiding this comment

metamaskbot commented Nov 20, 2024

fix: Gracefully handle bad responses from `net_version` calls to RPC endpoint when getting Provider Network State #27509

fix: Gracefully handle bad responses from `net_version` calls to RPC endpoint when getting Provider Network State #27509

jiexi commented Sep 30, 2024 •

edited by github-actions bot

Loading