Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow users to remove linea from networks list #27512

Merged
merged 17 commits into from
Oct 22, 2024
Merged

fix: Allow users to remove linea from networks list #27512

merged 17 commits into from
Oct 22, 2024

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Sep 30, 2024 •
edited
Loading

Description

Users should be allowed to remove Linea from networks list. When Linea is removed from default network list, it should appear within the Popular Networks section (be suggested to them). So, we need to also add it to FEATURED_RPCS

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-387

Manual testing steps

  1. Go to networks list, ensure that you can remove linea, even though it is a default network.

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review September 30, 2024 21:57
@gambinish gambinish requested a review from a team as a code owner September 30, 2024 21:57
@metamaskbot
Copy link
Collaborator

Builds ready [8c9bf20]
Page Load Metrics (1848 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28022661659517248
domContentLoaded145822561813260125
load146622661848264127
domInteractive248241199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

andreahaku
andreahaku previously approved these changes Oct 2, 2024
View reviewed changes
Copy link

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergeron
Copy link
Contributor

bergeron commented Oct 2, 2024 •
edited
Loading

Let's make sure if linea is deleted, it appears as a popular network so people have the ability to re-add it. The list of popular networks should be defined by FEATURED_RPCS so you can start with trying to add it there and see what breaks.

@metamaskbot
Copy link
Collaborator

Builds ready [5755063]
Page Load Metrics (1937 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157726351927288138
domContentLoaded156124911885251120
load157026411937288138
domInteractive197542189
backgroundConnect9208475024
firstReactRender723891206431
getState5116233014
initialActions01000
loadScripts11391803140216077
setupStore12110292612
uiStartup174231422198405195

@gambinish
Merge branch 'chore/MMASSETS-387_allow-users-to-remove-linea' of gith…
798bd1d 
…ub.com:MetaMask/metamask-extension into chore/MMASSETS-387_allow-users-to-remove-linea
@gambinish
Copy link
Contributor Author

gambinish commented Oct 15, 2024 •
edited
Loading

Let's make sure if linea is deleted, it appears as a popular network so people have the ability to re-add it. The list of popular networks should be defined by FEATURED_RPCS so you can start with trying to add it there and see what breaks.

Screen.Recording.2024-10-15.at.9.12.55.AM.mov

As far as I can tell, this is working as expected since Linea is already added as an entry of FEATURED_RPCS

Am I missing something here?

@metamaskbot
Copy link
Collaborator

Builds ready [3e25304]
Page Load Metrics (1919 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint157326881917253121
domContentLoaded156326791875236113
load157126901919265127
domInteractive18121472412
backgroundConnect8213445728
firstReactRender472141215727
getState4110233417
initialActions01000
loadScripts114021901405215103
setupStore10128533718
uiStartup181532082257403193
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@gambinish gambinish requested review from a team and bergeron October 16, 2024 01:56
@metamaskbot
Copy link
Collaborator

Builds ready [af20158]
Page Load Metrics (1884 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16932393189320398
domContentLoaded16622291184819594
load167023941884214103
domInteractive17246635828
backgroundConnect11159393617
firstReactRender46198923818
getState587252914
initialActions01000
loadScripts12221837139717684
setupStore1188272512
uiStartup186830632111285137
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@gambinish
Merge branch 'chore/MMASSETS-387_allow-users-to-remove-linea' of gith…
0c94bca 
…ub.com:MetaMask/metamask-extension into chore/MMASSETS-387_allow-users-to-remove-linea
@gambinish gambinish requested a review from a team as a code owner October 16, 2024 19:51
@gambinish
Copy link
Contributor Author

My bad. I had the changes to FEATURED_RPCS on my local 😑

Should be updated now.

@metamaskbot
Copy link
Collaborator

Builds ready [92e1d89]
Page Load Metrics (2371 ± 418 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint438560922961033496
domContentLoaded167649642323833400
load169452222371871418
domInteractive17154724220
backgroundConnect13323536732
firstReactRender4956314611756
getState6312376632
initialActions01000
loadScripts123338311765688331
setupStore12105433115
uiStartup1862653927411125540
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 211 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [c21904c]
Page Load Metrics (1978 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint171527931975327157
domContentLoaded165725801931289139
load171329301978342164
domInteractive198450189
backgroundConnect9379478039
firstReactRender472151085325
getState5112293316
initialActions01000
loadScripts123319731466221106
setupStore10198434522
uiStartup189342392291588283
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

@gambinish gambinish requested a review from wachunei October 16, 2024 23:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [cc8db41]
Page Load Metrics (1947 ± 147 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint171027611923278133
domContentLoaded167625771869224107
load171428591947306147
domInteractive278546178
backgroundConnect114257510048
firstReactRender473371248340
getState5192294522
initialActions01000
loadScripts12411879138415675
setupStore11221525727
uiStartup188542362296607292
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

@dabossdana dabossdana mentioned this pull request Oct 17, 2024
Closed
@gambinish gambinish removed the request for review from wachunei October 17, 2024 15:41
@metamaskbot
Copy link
Collaborator

Builds ready [715d648]
Page Load Metrics (1959 ± 154 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint165026751942256123
domContentLoaded16262207187417383
load163630561959322154
domInteractive15229745928
backgroundConnect87928017383
firstReactRender462181104622
getState4134223517
initialActions00000
loadScripts11931688140414972
setupStore11109413216
uiStartup183732992239433208
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

@gambinish
fix: Remove log
34bff12
@gambinish
Merge branch 'chore/MMASSETS-387_allow-users-to-remove-linea' of gith…
b356c50 
…ub.com:MetaMask/metamask-extension into chore/MMASSETS-387_allow-users-to-remove-linea
@metamaskbot
Copy link
Collaborator

Builds ready [b356c50]
Page Load Metrics (1976 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60030331839535257
domContentLoaded162230061943337162
load163230361976357172
domInteractive26119532512
backgroundConnect7242375125
firstReactRender45117892311
getState495192512
initialActions01000
loadScripts116920151441249120
setupStore1162272010
uiStartup179432552190398191
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [b356c50]
Page Load Metrics (1976 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint60030331839535257
domContentLoaded162230061943337162
load163230361976357172
domInteractive26119532512
backgroundConnect7242375125
firstReactRender45117892311
getState495192512
initialActions01000
loadScripts116920151441249120
setupStore1162272010
uiStartup179432552190398191
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

@gambinish gambinish enabled auto-merge October 22, 2024 16:53
@gambinish gambinish added this pull request to the merge queue Oct 22, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [bf5f6d2]
Page Load Metrics (2279 ± 89 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29625712078603289
domContentLoaded19432509224217182
load19492559227918689
domInteractive3193552110
backgroundConnect9123383115
firstReactRender732911295526
getState674312311
initialActions01000
loadScripts14001845165414067
setupStore1296372311
uiStartup223831632587239115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -39 Bytes (-0.00%)
  • common: 251 Bytes (0.00%)

Merged via the queue into develop with commit 6b94992 Oct 22, 2024
76 checks passed
@gambinish gambinish deleted the chore/MMASSETS-387_allow-users-to-remove-linea branch October 22, 2024 17:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bergeron bergeron bergeron approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@andreahaku andreahaku andreahaku left review comments

Assignees
No one assigned
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gambinish @metamaskbot @bergeron @andreahaku @sahar-fehri @vinnyhoward