Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snaps): Copyable more button color #27600

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Oct 3, 2024

Description

This fixes the Copyable component "more" button color.

Open in GitHub Codespaces

Related issues

Fixes: #27406

Manual testing steps

  1. Go to test-snaps
  2. Use the Interactive UI example snap
  3. enter a very large string in the first input
  4. submit the form

Screenshots/Recordings

Before

image
image

After

image
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner October 3, 2024 10:50
@GuillaumeRx GuillaumeRx force-pushed the gr/fix-copyable-more-button branch from db28850 to 7d76794 Compare October 3, 2024 10:50
@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarqubecloud bot commented Oct 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [7d76794]
Page Load Metrics (1948 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28624001865428205
domContentLoaded167623891914219105
load168724011948231111
domInteractive27176533316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@GuillaumeRx GuillaumeRx added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit 5281766 Oct 3, 2024
77 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/fix-copyable-more-button branch October 3, 2024 12:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix copyable more button being the wrong color
4 participants