Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change survey timeout time from a week to a day #27603

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 3, 2024

Description

Changes the survey time so that users check on a new survey every day instead of every week

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner October 3, 2024 16:55
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [830b02b]
Page Load Metrics (1757 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30622381555530255
domContentLoaded15772112172512259
load15852258175715374
domInteractive1791472110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jonybur jonybur enabled auto-merge October 3, 2024 18:33
@jonybur jonybur added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@jonybur jonybur removed this pull request from the merge queue due to a manual request Oct 4, 2024
@jonybur jonybur enabled auto-merge October 4, 2024 13:17
@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0fe3e2b]
Page Load Metrics (1896 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16582187189414168
domContentLoaded16312138186113264
load16402191189614369
domInteractive16101482211
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@jonybur jonybur enabled auto-merge October 4, 2024 14:08
Copy link

sonarqubecloud bot commented Oct 4, 2024

@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b9107c8]
Page Load Metrics (2007 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23627921828577277
domContentLoaded172727481961227109
load173927942007236113
domInteractive17100452311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@jonybur jonybur added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@jonybur jonybur added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit 4c3232c Oct 7, 2024
77 checks passed
@jonybur jonybur deleted the jb-change-survey-timeout branch October 7, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 7, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants