Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix reading address from market data #27604

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 3, 2024

Description

This PR fixes error when tokensMarketData sometimes resolves with a small delay which will result in an app error;

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Switch networks back and forth and you should not see the app crash

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review October 3, 2024 17:03
@sahar-fehri sahar-fehri requested a review from a team as a code owner October 3, 2024 17:03
@sahar-fehri sahar-fehri requested a review from gambinish October 3, 2024 17:11
@metamaskbot
Copy link
Collaborator

Builds ready [04196d0]
Page Load Metrics (1850 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38222451700474228
domContentLoaded153122051828223107
load153922201850224108
domInteractive23170533316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 15 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarqubecloud bot commented Oct 3, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [2d4de6e]
Page Load Metrics (1901 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint163224891904239115
domContentLoaded161924461864238114
load162724711901236113
domInteractive25118432311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 15 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 4, 2024
Merged via the queue into develop with commit b10ffa6 Oct 4, 2024
77 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-reading-undefined-from-market-data branch October 4, 2024 15:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 4, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants