Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove circular dependency between ui/ducks/custom-gas.js and ui/selectors/index.js #27640

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Oct 4, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-extension-platform Extension Platform team label Oct 4, 2024
@davidmurdoch davidmurdoch changed the base branch from develop to circles-001 October 4, 2024 17:36
@metamaskbot
Copy link
Collaborator

Builds ready [c53e42d]
Page Load Metrics (1677 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29126401607405195
domContentLoaded144725521649258124
load145426291677267128
domInteractive17119392110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 48 Bytes (0.00%)

@davidmurdoch davidmurdoch changed the base branch from circles-001 to develop October 8, 2024 16:01
@metamaskbot
Copy link
Collaborator

Builds ready [aea060f]
Page Load Metrics (1801 ± 113 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27023571750413198
domContentLoaded145422711771228109
load145822761801236113
domInteractive23159463115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 24 Bytes (0.00%)

@davidmurdoch davidmurdoch changed the title Circles 002 chore: remove circular dependency between ui/ducks/custom-gas.js and ui/selectors/index.js Oct 8, 2024
@davidmurdoch davidmurdoch added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Oct 9, 2024
@davidmurdoch davidmurdoch changed the title chore: remove circular dependency between ui/ducks/custom-gas.js and ui/selectors/index.js refactor: remove circular dependency between ui/ducks/custom-gas.js and ui/selectors/index.js Oct 9, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [ff98de0]
Page Load Metrics (1855 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16342214184915273
domContentLoaded16212096182013866
load16292246185515675
domInteractive247343168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 24 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review October 16, 2024 14:56
@davidmurdoch davidmurdoch requested a review from a team as a code owner October 16, 2024 14:56
@MajorLift MajorLift added this pull request to the merge queue Oct 21, 2024
@MajorLift MajorLift removed this pull request from the merge queue due to a manual request Oct 21, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@HowardBraham HowardBraham added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit d473e13 Oct 22, 2024
85 checks passed
@HowardBraham HowardBraham deleted the circles-002 branch October 22, 2024 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-extension-platform Extension Platform team team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants