Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated toasts component and copy #27656

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: updated toasts component and copy #27656

merged 3 commits into from
Oct 10, 2024

Conversation

NidhiKJha
Copy link
Member

This PR is to update the toast component and update the copy changes for the toast

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3389

Manual testing steps

  1. Run extension with CHAIN_PERMISSIONS=1 yarn start
  2. Check the toast component, it has border radius, box shadow and other fixes as described in ticket

Screenshots/Recordings

Before

Screenshot 2024-10-07 at 12 33 08 PM

After

Screenshot 2024-10-07 at 12 33 52 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested review from a team as code owners October 7, 2024 11:34
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 7, 2024
@NidhiKJha NidhiKJha added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Oct 7, 2024
Copy link

sonarqubecloud bot commented Oct 8, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [9f454fc]
Page Load Metrics (1950 ± 173 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23432761877517248
domContentLoaded166132511918361173
load167432761950360173
domInteractive1710145199
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -61 Bytes (-0.00%)
  • common: -111 Bytes (-0.00%)

Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use a new localization key so that other messages get re-translated.

@NidhiKJha
Copy link
Member Author

We need to use a new localization key so that other messages get re-translated.

@darkwing This localization key is not translated yet. It only exists in en file. So, I think we can use it. Right?

@NidhiKJha NidhiKJha requested a review from darkwing October 8, 2024 19:40
Copy link

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha added this pull request to the merge queue Oct 10, 2024
Merged via the queue into develop with commit 875ab21 Oct 10, 2024
78 checks passed
@NidhiKJha NidhiKJha deleted the fix-3389 branch October 10, 2024 13:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 10, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants