-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no connected state for permissions page #27660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [ca4fb3e]
Page Load Metrics (1955 ± 135 ms)
Bundle size diffs
|
Builds ready [75fed70]
Page Load Metrics (2044 ± 74 ms)
Bundle size diffs
|
vinnyhoward
approved these changes
Oct 8, 2024
NidhiKJha
changed the title
fixed no connected state for permissions page
fix: no connected state for permissions page
Oct 10, 2024
Builds ready [48ffeba]
Page Load Metrics (1784 ± 104 ms)
Bundle size diffs
|
sahar-fehri
approved these changes
Oct 10, 2024
salimtb
approved these changes
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
Quality Gate passedIssues Measures |
Builds ready [702dd58]
Page Load Metrics (1945 ± 78 ms)
Bundle size diffs
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 14, 2024
metamaskbot
added
the
release-12.7.0
Issue or pull request that will be included in release 12.7.0
label
Oct 14, 2024
gauthierpetetin
added
release-12.6.0
Issue or pull request that will be included in release 12.6.0
and removed
release-12.7.0
Issue or pull request that will be included in release 12.7.0
labels
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add padding to the permissions page when no site or snap is connected
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist