Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove phishing detection from onboarding Security group #27819

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Oct 14, 2024

Description

Screenshot 2024-10-14 at 11 57 53`

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3497

Manual testing steps

  1. Onboard
  2. Go to "Reminder set!" screen
  3. Click on "Manage default settings"
  4. Click on "Security"
  5. Check that there's no

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner October 14, 2024 11:04
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [1d05886]
Page Load Metrics (2401 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48028202325459221
domContentLoaded20112772235916981
load20642811240116881
domInteractive32155632412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -244 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [1d05886]
Page Load Metrics (2401 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48028202325459221
domContentLoaded20112772235916981
load20642811240116881
domInteractive32155632412
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -244 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonybur jonybur added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit bf31876 Oct 14, 2024
78 checks passed
@jonybur jonybur deleted the jb-remove-phishing-from-onboarding branch October 14, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 14, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants