Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NFT permit simulations #27825

Merged
merged 12 commits into from
Oct 17, 2024
Merged

feat: NFT permit simulations #27825

merged 12 commits into from
Oct 17, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 14, 2024

Description

Add simulation section to NFT permit

Related issues

Fixes: #27394

Manual testing steps

  1. Submit NFT permit signature request
  2. Check simulation section on the confirmation page

Screenshots/Recordings

Screenshot 2024-10-14 at 5 40 21 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 14, 2024
@jpuri jpuri requested a review from a team as a code owner October 14, 2024 12:44
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 16, 2024
Base automatically changed from nft_permit to develop October 16, 2024 15:16
@jpuri jpuri dismissed matthewwalsh0’s stale review October 16, 2024 15:16

The base branch was changed.

@MajorLift MajorLift requested a review from a team as a code owner October 16, 2024 15:16
Copy link

@jpuri jpuri requested a review from matthewwalsh0 October 16, 2024 15:48
@metamaskbot
Copy link
Collaborator

Builds ready [5843cf8]
Page Load Metrics (1699 ± 167 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint142327031691336161
domContentLoaded141425161643271130
load142527111699347167
domInteractive19192503818
backgroundConnect9431589546
firstReactRender432031094923
getState4238325728
initialActions0724168
loadScripts102319651229219105
setupStore10147353919
uiStartup160441352034635305
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 166 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@jpuri jpuri added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@jpuri jpuri added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@jpuri jpuri added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit fac4422 Oct 17, 2024
78 checks passed
@jpuri jpuri deleted the nft_permit_simulations branch October 17, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 17, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support ERC-721 Permit Simulations
6 participants