fix: remove scroll-to-bottom requirement in redesigned transaction confirmations #27910
+30
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Builds ready [7f55b70]
Page Load Metrics (1780 ± 96 ms)
Bundle size diffs
|
vinistevam
changed the title
OGPoyraz
reviewed
Oct 17, 2024
| setIsScrollToBottomCompleted(true); | ||
| return; | ||
| } | ||
|
|
||
| setIsScrollToBottomCompleted(!isScrollable || hasScrolledToBottom); | ||
| }, [isScrollable, hasScrolledToBottom]); |
There was a problem hiding this comment.
Should this hook to have isTransactionRedesign dependency?
There was a problem hiding this comment.
Great catch, done.
OGPoyraz
reviewed
Oct 17, 2024
| @@ -49,6 +51,13 @@ const ScrollToBottom = ({ children }: ContentProps) => { | |||
| offsetPxFromBottom: 0, | |||
| }); | |||
|
|
|||
| const isTransactionRedesign = REDESIGN_USER_TRANSACTION_TYPES.includes( | |||
There was a problem hiding this comment.
Maybe a dumb question, this should definitely check if current confirmation in REDESIGN_USER_TRANSACTION_TYPES but also if user opted-in for redesigned transactions?
There was a problem hiding this comment.
I assumed ScrollToBottom is used only for redesigned confirmations. I will double-check.
There was a problem hiding this comment.
That make sense if that's the case
There was a problem hiding this comment.
In this case we probably want to use REDESIGN_DEV_TRANSACTION_TYPES instead, which is a superset of REDESIGN_USER_TRANSACTION_TYPES and includes any types not yet visible to the user but already in active development
OGPoyraz
previously approved these changes
Oct 17, 2024
vinistevam
force-pushed
the
fix/remove-scroll-to-bottom-transaction
branch
2 times, most recently
from
42027be to
b344e29
Compare
Builds ready [e53536f]
Page Load Metrics (1912 ± 189 ms)
Bundle size diffs
|
pedronfigueiredo
previously approved these changes
Oct 21, 2024
jpuri
previously approved these changes
Oct 21, 2024
Builds ready [35c228a]
Page Load Metrics (1867 ± 61 ms)
Bundle size diffs
|
vinistevam
dismissed stale reviews from pedronfigueiredo and jpuri
via
bdf56de
vinistevam
force-pushed
the
fix/remove-scroll-to-bottom-transaction
branch
from
1cd0727 to
bdf56de
Compare
Builds ready [c24e021]
Page Load Metrics (2009 ± 51 ms)
Bundle size diffs
|
OGPoyraz
approved these changes
Nov 4, 2024
digiwand
approved these changes
Nov 5, 2024
Builds ready [b7155f2]
Page Load Metrics (1735 ± 34 ms)
Bundle size diffs
|
Builds ready [2fdb1dd]
Page Load Metrics (2090 ± 63 ms)
Bundle size diffs
|
metamaskbot
added
the
release-12.8.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the removal of the scroll-to-bottom requirement in the redesigned transaction confirmation screens. It eliminates the need for users to scroll to the bottom in order to enable the confirm button, streamlining the confirmation process. The scroll-to-bottom arrow is also removed, ensuring a smoother user experience without unnecessary interaction barriers.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3495
Manual testing steps
Screenshots/Recordings
deploy.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist