test: [POM] Migrate contract interaction with snap account e2e tests to page object modal #27924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Moved snap-account-contract-interaction.spec.ts and snap-account-signatures-and-disconnects.spec.ts to test/e2e/tests/account/ - Created new page object files: account-menu.ts, activity-list.ts, signature-request-page.ts, snap-account-page.ts, test-dapp.ts, transaction-confirmation.ts - Updated tsconfig.json to include esModuleInterop - Updated package.json and yarn.lock with new dependencies
chloeYue
reviewed
Oct 17, 2024
| import { createBtcAccount } from '../../accounts/common'; | ||
| import messages from '../../../../app/_locales/en/messages.json'; | ||
|
|
||
| export async function createBtcAccount(driver: Driver) { |
There was a problem hiding this comment.
move this method from accounts/common file to this file
…ithub.com/MetaMask/metamask-extension into migrate-snap-account-contract-interaction
chloeYue
changed the title
Builds ready [fb83141]
Page Load Metrics (1920 ± 167 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
Oct 17, 2024
| @@ -18,6 +18,7 @@ import SnapSimpleKeyringPage from '../../page-objects/pages/snap-simple-keyring- | |||
| import TestDapp from '../../page-objects/pages/test-dapp'; | |||
|
|
|||
| describe('Snap Account Signatures @no-mmi', function (this: Suite) { | |||
| this.timeout(120000); // This test is very long, so we need an unusually high timeout | |||
DDDDDanica
approved these changes
Oct 17, 2024
chloeYue
approved these changes
Oct 18, 2024
metamaskbot
added
the
release-12.8.0
gauthierpetetin
added
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the snap account contract interaction e2e tests to Page Object Model (POM) pattern, improving test stability and maintainability.
Changes include:
snap-account-contract-interaction.spec.tsto POMsnap-account-signatures-and-disconnects.spec.tsto POMRelated issues
Fixes: #27933
Manual testing steps
Check code readability, make sure tests pass.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist