Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide options menu that was being shown for preinstalled Snaps #27937

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Oct 17, 2024

Description

This PR will hide Snaps options menu and info icon in Snaps header for preinstalled Snaps.

Open in GitHub Codespaces

Related issues

Fixes: n/a

Manual testing steps

  1. Go to Account watcher Snap and make sure that there is no button with three dots in Snaps header.
  2. Go to ordinary Home Page Snap and make sure that three dots are available there.
  3. Go to ordinary (non-preinstalled) custom UI Snap with confirmation popup of any type and make sure that there is Info icon in the right corner of the header.

Screenshots/Recordings

Before

image

After

Screenshot 2024-10-17 at 17 44 34
Screenshot 2024-10-17 at 17 45 26
Screenshot 2024-10-17 at 17 46 03

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@david0xd david0xd added the team-snaps-platform Snaps Platform team label Oct 17, 2024
@david0xd david0xd self-assigned this Oct 17, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@david0xd david0xd added team-snaps-platform Snaps Platform team and removed team-snaps-platform Snaps Platform team labels Oct 17, 2024
@david0xd david0xd marked this pull request as ready for review October 17, 2024 15:50
@david0xd david0xd requested review from a team as code owners October 17, 2024 15:50
@metamaskbot
Copy link
Collaborator

Builds ready [57c929c]
Page Load Metrics (2010 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint176728262017230110
domContentLoaded175627391987211101
load177027492010208100
domInteractive1790472311
backgroundConnect1072292110
firstReactRender582091043215
getState567202010
initialActions01000
loadScripts12562201147419996
setupStore1288262311
uiStartup198330422241233112
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 24 Bytes (0.00%)
  • common: 16 Bytes (0.00%)

Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and manually tested:

Screenshot 2024-10-17 at 21 15 05
Screenshot 2024-10-17 at 21 16 25
Screenshot 2024-10-17 at 21 24 17
Screenshot 2024-10-17 at 21 25 18

@david0xd david0xd added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 35b86fc Oct 17, 2024
87 of 88 checks passed
@david0xd david0xd deleted the dd/fix-snap-header-options branch October 17, 2024 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Oct 17, 2024
@gauthierpetetin gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.8.0 Issue or pull request that will be included in release 12.8.0 labels Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants