Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: notifications integration tests #28022

Merged
merged 29 commits into from
Oct 24, 2024
Merged

Conversation

cmd-ob
Copy link
Contributor

@cmd-ob cmd-ob commented Oct 22, 2024

Description

First set of integration tests for notifications feature
Adds Tests for:

  • Turning on notifications for first time
  • Marking notifications as read
  • Disabling notifications
  • Toggling product announcements
  • Metametrics for all the above

Open in GitHub Codespaces

Related issues

https://consensyssoftware.atlassian.net/browse/NOTIFY-1259

Manual testing steps

  1. Run integration tests using yarn test:integration
  2. All tests should pass

Screenshots/Recordings

Screenshot 2024-10-22 at 21 00 13

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cmd-ob cmd-ob requested review from a team as code owners October 22, 2024 19:54
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cmd-ob cmd-ob marked this pull request as draft October 22, 2024 19:57
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Oct 23, 2024
matteoscurati
matteoscurati previously approved these changes Oct 23, 2024
Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [a4a4795]
Page Load Metrics (2094 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint54326052025398191
domContentLoaded17052594206219393
load17162608209419996
domInteractive1890452110
backgroundConnect986352512
firstReactRender6411997126
getState570212110
initialActions00000
loadScripts12152063152017986
setupStore1575462512
uiStartup193528402321211101
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 139 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [4cd7f22]
Page Load Metrics (2022 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint175028562025290139
domContentLoaded169227401992269129
load174928592022291140
domInteractive1386412010
backgroundConnect9117283014
firstReactRender462901135928
getState568242411
initialActions01000
loadScripts123721221478230111
setupStore1283422512
uiStartup195431482293317152
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 139 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [8604e4c]
Page Load Metrics (2055 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint171530702056336162
domContentLoaded167429982011322155
load171330752055345166
domInteractive23171613617
backgroundConnect10135433115
firstReactRender50107762211
getState590282311
initialActions01000
loadScripts122824421525307147
setupStore126432199
uiStartup192833332261362174
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 139 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmd-ob cmd-ob added this pull request to the merge queue Oct 24, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [ac9e37a]
Page Load Metrics (2005 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint173124342005214103
domContentLoaded17172416197320598
load173524352005217104
domInteractive15157543316
backgroundConnect11121282813
firstReactRender50125892311
getState587272814
initialActions00000
loadScripts12201912148419594
setupStore1293492512
uiStartup192128882257249120
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 139 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into develop with commit da377be Oct 24, 2024
76 checks passed
@cmd-ob cmd-ob deleted the nofitications-integration-tests branch October 24, 2024 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@metamaskbot metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.7.0 Issue or pull request that will be included in release 12.7.0 team-notifications Notifications team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants