chore: bump asset controllers to 39 + polling API #28025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/controller-utils@11.3.0 |
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
…ask-extension into brian/asset-controller-39
Builds ready [04ea3d6]
Page Load Metrics (1938 ± 90 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
bergeron
changed the title
Builds ready [cf66072]
Page Load Metrics (1832 ± 79 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
gambinish
reviewed
Oct 24, 2024
| @@ -16,9 +16,10 @@ const useCurrencyRatePolling = (networkClientId?: string) => { | |||
| const selectedNetworkClientId = useSelector(getSelectedNetworkClientId); | |||
|
|
|||
| usePolling({ | |||
| startPollingByNetworkClientId: currencyRateStartPollingByNetworkClientId, | |||
| startPolling: (input) => | |||
| currencyRateStartPollingByNetworkClientId(input.networkClientId), | |||
There was a problem hiding this comment.
Can you help me understand why we aren't updating the action to also be currencyRateStartPolling?
There was a problem hiding this comment.
in actions.ts i kept the function name currencyRateStartPollingByNetworkClientId to minimize changes since it does still accept a network client id (for now)
gambinish
approved these changes
Oct 24, 2024
7 tasks
Builds ready [b93a15d]
Page Load Metrics (1851 ± 57 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [b93a15d]
Page Load Metrics (1851 ± 57 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
darkwing
approved these changes
Oct 28, 2024
matthewwalsh0
approved these changes
Oct 29, 2024
7 tasks
metamaskbot
added
the
release-12.7.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps the asset controllers to 39. In this version, the polling API has changed from
startPollingByNetworkClientIdto a more flexiblestartPollingthat can accept any input. TheusePollinghook is modified to accommodate this.Related issues
Manual testing steps
Should be no noticeable changes. Currency rates should continue to be fetched. Try switching between chains with different native currencies like mainnet, polygon, bnb and verify the native token has fiat prices.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist